-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better control over printing of CONECT records to PDB files. #840
Conversation
… requested (i.e. comply with pdb v3 format), only print CONECT for HETATM residues, otherwise print CONECT for all bonds. A new keyword called 'conectmode' has been added that can override this behavior.
The PGI build in Jenkins failed. |
1 similar comment
The PGI build in Jenkins failed. |
@swails So the PGI failure seems like the old machine-specific one. I notice that the Jenkinsfile changed from PGI requiring Also, the Pytraj failure can probably be fixed by sourcing the All that said, I've independently verified that everything builds and tests with PGI, so I think this is safe to merge. |
Batwoman is a very old machine (ca. 2011) with a Xeon processor. The other Intel CPU machines all have modern i5s (3 machines with 9400F). I'm a little wary of tying the PGI build to the oldest machine in the array since if it goes down, no build can finish. When the machine-specific issue first arose, the two machines in the Jenkins array was an AMD FX-6100 (ca 2012) and a Xeon X5675 (ca 2011), and it only worked on the Xeon. Give me a few days to dig a little and see what I can find. Alternatively, I can grant you ssh access to Green Lantern if you wanted to dig, as well. |
Previously, CONECT records were printed for all bonds if
conect
was specified, or only HETATM residues ifpdbres
/pdbv3
had been specified. This PR adds a new keyword,conectmode
, which allows more direct control over the printing of CONECT records:Manual updated and test added.