-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and improvements for SPAM and volmap, 3d grids #838
Conversation
…for OpenDX files, option to read grids in as double precision, enable DIV and MULT for grids, warn if extra args remain after 'purewater' specified for SPAM, use DataSet/DataFile framework for peaks in SPAM, add DataIO for read and write of peaks data, fix Tinker file recognition, make sure SPAM is not hidden, skip peaks where bin calc could overflow, avoid using zero bandwidth for KDE hist when only 1 value available.
…p to be compiled double precision if desired. Fix some uninitialized vars.
The PGI build in Jenkins failed. |
Weird - Jenkins says PGI failed again, but it clearly passed. |
Travis-CI mac framework is having issues:
I'll try to restart in a bit I guess... |
😠 The Mac stuff is still failing |
OK, the real error is a few lines above:
Indeed, trying that URL results in a |
Looks like Mac builds on Travis are finally working again! |
It actually didn't pass. The problem is that if that stage itself failed, then the entire pipeline would fail (which we don't want). If you click on the green PGI stage in the Blue Ocean UI, you will see the individual steps, and the build/test step is red: The PR post is placed in the The whole point behind having the pipeline post to a PR when the PGI build fails is so we can be notified if it didn't pass without making the whole Jenkins pipeline fail (which would block it from building the libcpptraj docker image and testing pytraj against it). As an aside, the latest master build doesn't work with pytraj it seems. @hainm, are you aware of this? |
The error is here: |
This PR has multiple fixes and improvements related to SPAM, volmap and reading/writing 3D data.
volmap
command now creates a data set for the peaks data. This means that among other things you can runspam
andvolmap
in the same cpptraj run. This could include running volmap several times with the same peak data and different settings.spam
to trap "bad" peaks (poor occupancy, extremely large energies, etc) that previously could lead to the code producing nonsense or failing outright.dataset precision
) from the default of%g
.Miscellaneous fixes: