Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): createPagination option is for pagination #126

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

ExFlo
Copy link
Contributor

@ExFlo ExFlo commented Sep 9, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #126 (ecc7b90) into main (46cbb27) will decrease coverage by 4.90%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   93.20%   88.31%   -4.90%     
==========================================
  Files          70       53      -17     
  Lines        5314     1386    -3928     
  Branches      461      218     -243     
==========================================
- Hits         4953     1224    -3729     
+ Misses        314      125     -189     
+ Partials       47       37      -10     
Flag Coverage Δ
e2e-1 59.13% <100.00%> (-5.94%) ⬇️
e2e-2 37.08% <66.66%> (+18.91%) ⬆️
e2e-4 61.65% <100.00%> (-13.12%) ⬇️
e2e-5 47.47% <100.00%> (-0.15%) ⬇️
e2e-7 59.20% <100.00%> (-0.08%) ⬇️
e2e-8 50.34% <100.00%> (+19.07%) ⬆️
unit 91.77% <100.00%> (-6.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
core/lib/pagination.ts 100.00% <ø> (ø)
angular/lib/src/lib/modal/modal.service.ts 68.42% <100.00%> (-6.58%) ⬇️
core/lib/services/stores.ts 98.71% <100.00%> (-0.24%) ⬇️

... and 52 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@quentinderoubaix quentinderoubaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thx @ExFlo !

@quentinderoubaix quentinderoubaix merged commit e3886cb into AmadeusITGroup:main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants