Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic hiDPI support #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Calinou
Copy link
Contributor

@Calinou Calinou commented Dec 27, 2019

This upscales the game by a factor of 2 on hiDPI displays. The end result will be pixelated, but this makes the game playable on such displays.

This upscales the game by a factor of 2 on hiDPI displays.
The end result will be pixelated, but this makes the game playable
on such displays.
@skyace65
Copy link
Collaborator

skyace65 commented Jan 2, 2020

Isn't the proper way to do hiDPI with stretch settings? Though I have had issues getting those to work properly.

Also I wanted to thank you for all the pull requests. It's nice having someone new help with this.

@Calinou
Copy link
Contributor Author

Calinou commented Jan 2, 2020

@skyace65 The game uses the disabled stretch mode right now. We could switch to the 2d stretch mode and increase the base resolution, but this may make things too large on larger displays. I have a Godot pull request that adds a custom scale factor to the 2d stretch mode, but it'll only be mergeable for 4.0.

Still, if we decide to use the 2d stretch mode, we can always multiply the camera zoom value by the automatic stretch factor to compensate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants