Show notification if FlightCore is outdated #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alystrasz
pushed a commit
that referenced
this pull request
Oct 10, 2022
* feat: Show own version number in settings view Adds a new field to state that stores FlightCore version number. Version number is pulled from backend on application launch. * style: Reorder so that FC version is shown first * chore: Remove leftover TODO comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notification is set to not auto-expiry to avoid the case of the user missing it due to opening the application in the background.
For the future it would be nice to also have a watermark in the background that shows if FlightCore is outdated to be able to immediately tell in any support ticket whether the issue the user is having is simply caused by an outdated version of FlightCore but this is good enough for the UI rewrite PR right now.
Also strips unused copied code that was previously in the same area.