Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

213 Upgrade to dotnet 9 #236

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

213 Upgrade to dotnet 9 #236

wants to merge 1 commit into from

Conversation

sigridbra
Copy link

@sigridbra sigridbra commented Feb 7, 2025

Description

Update the target .NET framework to version 9.0.
Also includes major upgrades from 1.x.x to 2.0.0 for:

  • Microsoft.Azure.Functions.Worker.Sdk
  • Microsoft.Azure.Functions.Worker
  • Microsoft.Azure.Functions.Worker.ApplicationInsights

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Copy link

sonarqubecloud bot commented Feb 7, 2025

@sigridbra sigridbra requested a review from a team February 7, 2025 12:50
Copy link
Contributor

@hggutvik hggutvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 🏅
There's one part I'd like Terje to check out before you complete and merge.
I also added a small notice in the PR description, about the major upgrade to v2.0.0 of Functions Worker packages. Might be worth highlighting.

@@ -31,11 +31,11 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4

- name: Setup .NET 8.0.* SDK
- name: Setup .NET 9.0.* SDK
uses: actions/setup-dotnet@v4
with:
dotnet-version: |
Copy link
Contributor

@hggutvik hggutvik Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SandGrainOne , about the versions v6 and 7 here. Keep or delete?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove 6 and 7.

I like to believe this is all we need to do, but the function app to where the function is deployed are created by a terraform script that might still refer to .net 8. I don't know if that is something we can just ignore or not. I haven't investigated. It would seem almost impossible to upgrade a function if it is hard locked to the function app definition in Azure.

Copy link
Member

@SandGrainOne SandGrainOne Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  site_config {
    always_on                = true
    application_insights_key = data.azurerm_application_insights.platform.instrumentation_key

    application_stack {
      dotnet_version              = "v8.0"
      use_dotnet_isolated_runtime = true
    }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent point, @SandGrainOne. @sigridbra , let's make the required Terraform changes together on Monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants