feat: ListItem - minor updates to api and default behaviour #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 31, 2025 11:21
…listBase and ListItemBase into ul and li elements respectably to inform screen readers of their roles
added 6 commits
February 6, 2025 08:42
…to feat/update-list-item-component
sonwit
reviewed
Feb 7, 2025
sonwit
reviewed
Feb 7, 2025
sonwit
reviewed
Feb 7, 2025
sonwit
reviewed
Feb 7, 2025
sonwit
reviewed
Feb 7, 2025
sonwit
approved these changes
Feb 7, 2025
seanes
reviewed
Feb 7, 2025
|
Great work @allinox 🥳 👍 - Just a minor comment on moving basic props to |
seanes
approved these changes
Feb 7, 2025
added 2 commits
February 7, 2025 14:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed link icon as chevron and made it default to not visible to make the component easier to use. Made listBase and ListItemBase into ul and li elements respectably to inform screen readers of their roles
Note: There are some accessibility issues with this component as it stands right now. Mainly due to the expanded state, and the appearance/disappearance of the button that opens it. Fixing this though, will require deeper changes in the ListItem component and it's structure, which should probably be discussed and made together with the change in click-area with control actions.
Related Issue(s)
Verification
Documentation