Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24.8 Backport of #70332 -- Passing external user roles from query originator to other nodes #542

Open
wants to merge 13 commits into
base: customizations/24.8.8
Choose a base branch
from

Conversation

zvonand
Copy link
Collaborator

@zvonand zvonand commented Dec 3, 2024

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Push external user roles from query originator to other nodes in cluster. Helpful when only originator has access to the external authenticator (like LDAP). (ClickHouse#63781 by @yakov-olkhovskiy, ClickHouse#64448 by @devcrafter, ClickHouse#69602 by @nickitat, ClickHouse#68424 by @nickitat, ClickHouse#69744 by @nickitat, ClickHouse#69706 by @nickitat, ClickHouse#68355 by @zvonand, ClickHouse#63151 by @alexey-milovidov, ClickHouse#70332 by @zvonand, ClickHouse#72759 by @zvonand, ClickHouse#65832 by @CurtizJ)

@zvonand zvonand force-pushed the backports/24.8/remote-roles-push branch from aa07aaf to 9feeddb Compare December 3, 2024 09:50
@altinity-robot
Copy link
Collaborator

altinity-robot commented Dec 3, 2024

This is an automated comment for commit a558b75 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Sign aarch64There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS❌ error
Sign releaseThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS❌ error
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ error
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ error
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Ready for releaseThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success

@zvonand zvonand changed the title Backports/24.8/remote roles push 24.8 Backport of #70332 -- Passing external user roles from query originator to other nodes Dec 3, 2024
@zvonand
Copy link
Collaborator Author

zvonand commented Dec 9, 2024

@Enmk there are some integration tests. It does not look like they are directly related to these changes, but they are somewhere nearby

@zvonand zvonand force-pushed the backports/24.8/remote-roles-push branch 2 times, most recently from 1596594 to 19481de Compare December 17, 2024 15:30
@zvonand
Copy link
Collaborator Author

zvonand commented Dec 19, 2024

@Enmk I think this one can be merged -- I fixed unique fails (they happened due to presence of not-yet-introduced settings in SettingsChangesHistory.cpp), now the set of fails is like in other backport PRs.

yakov-olkhovskiy and others added 13 commits December 22, 2024 17:37
…al_announce_from_RFMT

Remove explicit announce from local replica in ReadFromMergeTree
…_replicas

Adaptive mark_segment_size for parallel replicas
Passing external user roles from query originator to other nodes
Fix ClickHouse#72756 (exception in RemoteQueryExecutor when user does not exist locally)
Improved getting of alter conversions for queries
@Enmk Enmk force-pushed the backports/24.8/remote-roles-push branch from ca5b435 to a558b75 Compare December 22, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.