SignRelease cherrypick #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enmk
reviewed
Jun 5, 2023
tests/ci/env_helper.py
Outdated
| @@ -11,6 +11,8 @@ | |||
|
|
|||
| CACHES_PATH = os.getenv("CACHES_PATH", TEMP_PATH) | |||
| CLOUDFLARE_TOKEN = os.getenv("CLOUDFLARE_TOKEN") | |||
| GPG_BINARY_SIGNING_KEY = os.getenv("GPG_BINARY_SIGNING_KEY") | |||
There was a problem hiding this comment.
doesn't that mean that signing keys are available to every other step too?
There was a problem hiding this comment.
Maybe it is better to move that code to sign_release.py ?
There was a problem hiding this comment.
The signing keys are in the environment, so they are already available to all steps.
Will move the import.
Enmk
added a commit
that referenced
this pull request
Jun 24, 2023
23.3 Port of #266 Signing binaries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the signing and sha256 files back to the build process.