fix: loader for saving documentation

AltimateAI · Nov 18, 2024 · 42eb8bc · 42eb8bc
1 parent 84cb9ef
commit 42eb8bc
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 7 deletions.
diff --git a/src/webview_provider/docsEditPanel.ts b/src/webview_provider/docsEditPanel.ts
@@ -734,6 +734,24 @@ export class DocsEditViewPanel implements WebviewViewProvider {
               () => this.saveDocumentation(message, syncRequestId),
             );
             break;
+          case "saveDocumentationBulk": {
+            this.telemetry.sendTelemetryEvent(
+              TelemetryEvents["DocumentationEditor/SaveClick"],
+            );
+            window.withProgress(
+              {
+                title: "Saving documentation",
+                location: ProgressLocation.Notification,
+                cancellable: false,
+              },
+              async () => {
+                for (const item of message.models) {
+                  await this.saveDocumentation(item, syncRequestId);
+                }
+              },
+            );
+            break;
+          }
         }
       },
       null,

diff --git a/...ules/documentationEditor/components/documentationPropagation/DocumentationPropagation.tsx b/...ules/documentationEditor/components/documentationPropagation/DocumentationPropagation.tsx
@@ -8,7 +8,6 @@ import {
   executeRequestInSync,
 } from "@modules/app/requestExecutor";
 import { ColumnLineage } from "@lib";
-import { panelLogger } from "@modules/logger";
 import styles from "./styles.module.scss";
 
 interface Props {
@@ -141,14 +140,15 @@ export const DocumentationPropagationButton = ({
       ? defaultPackageName + "://models/schema.yml"
       : "";
 
+    const req = [];
+
     for (const item of allColumns) {
       const key = item.model + "/" + item.column;
       if (!selectedColumns[key]) continue;
       const splits = item.model.split(".");
       const modelName = splits[splits.length - 1];
       const node = tableMetadata.find((t) => t.table === item.model);
-
-      const result = (await executeRequestInSync("saveDocumentation", {
+      req.push({
         name: modelName,
         description: node?.description,
         columns: [{ name: item.column, description: currColumnDescription }],
@@ -157,11 +157,10 @@ export const DocumentationPropagationButton = ({
         patchPath: node?.patchPath || defaultPatchPath,
         filePath: node?.url,
         updatedTests: testsMetadata[item.model],
-      })) as { saved: boolean };
-      if (!result.saved) {
-        panelLogger.error("Unable to save documentation", item);
-      }
+      });
     }
+
+    await executeRequestInSync("saveDocumentationBulk", { models: req });
   };
 
   const setAllColumnsValue = (value: boolean) => {