fix: remove extra forbid constraint #48
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 831b509 in 30 seconds
More details
- Looked at
233lines of code in3files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. src/datapilot/core/platforms/dbt/schemas/catalog.py:12
- Draft comment:
Removingmodel_configwithextra=Extra.forbidwill allow extra fields in the data without raising an error. Ensure this change is intentional and aligns with the data validation requirements. - Reason this comment was not posted:
Comment did not seem useful.
2. src/datapilot/core/platforms/dbt/schemas/manifest.py:46
- Draft comment:
Removingmodel_configwithextra=Extra.forbidwill allow extra fields in the data without raising an error. Ensure this change is intentional and aligns with the data validation requirements. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_cFbsAuJt0xumqK2X
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 38dad6d in 42 seconds
More details
- Looked at
32lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/datapilot/core/platforms/dbt/schemas/manifest.py:49
- Draft comment:
The use ofOptional[Optional[str]]is redundant. Simplify toOptional[str]. This pattern appears in multiple places in this file and incatalog.py. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_tZxoNpvHIsWxGwNZ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
…EOL and failing due to rust also for now)
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 43a5d84 in 10 seconds
More details
- Looked at
22lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. tox.ini:17
- Draft comment:
Thepy38environment has been removed from theenvlist. If this was intentional, please ensure that all dependencies and tests are compatible with the remaining environments. If not, consider adding it back. - Reason this comment was not posted:
Confidence changes required:50%
The PR modifies theenvlistin thetox.inifile to includepydantic28andpydantic210constraints. However, thepy38environment is removed without explanation, which might be unintentional.
Workflow ID: wflow_N8IzOLGhKcwnre2r
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on e409801 in 18 seconds
More details
- Looked at
186lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/github-actions.yml:73
- Draft comment:
The PR description mentions removing an extra forbid constraint, but the changes in the PR are related to adding new test environments for different Python and Pydantic versions. This seems unrelated to the description. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_ruWyo7NjcS6VI2hR
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on cde2195 in 33 seconds
More details
- Looked at
24lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. tox.ini:18
- Draft comment:
The PR title mentions removing an extra forbid constraint, but the changes here are about adding Python 3.8 and PyPy 3.8 to the test environments. Ensure the PR title accurately reflects the changes made. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_AjunABqFI3hCT5D4
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on f717673 in 42 seconds
More details
- Looked at
22lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_8Fh4Ed4jcVOsNvIC
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 72d22ce in 21 seconds
More details
- Looked at
47lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/github-actions.yml:265
- Draft comment:
The removal of the commented-out pypy3.8 environments is consistent with the PR title and does not affect the current workflow execution. Ensure that these environments are no longer needed before finalizing the removal. - Reason this comment was not posted:
Confidence changes required:20%
The PR removes commented-out sections for pypy3.8 environments, which is consistent with the title 'remove extra forbid constraint'.
Workflow ID: wflow_p3YlDQyZFanzY90L
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ffae1f8 in 33 seconds
More details
- Looked at
428lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. tox.ini:17
- Draft comment:
Remove thepy38entry from thebasepythonsection as Python 3.8 is no longer part of the test matrix. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_QgsXhVaKuG1OFzBr
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on e598b5e in 15 seconds
More details
- Looked at
58lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/github-actions.yml:19
- Draft comment:
Removing comments that indicate the Python version is unnecessary and reduces readability. Consider keeping them for clarity. This applies to other similar removals in the file. - Reason this comment was not posted:
Confidence changes required:50%
The removal of comments is unnecessary and reduces code readability.
Workflow ID: wflow_q5eafWcPH7wjY1Sd
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 1514bf1 in 17 seconds
More details
- Looked at
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/github-actions.yml:177
- Draft comment:
The PR description mentions removing an extra forbid constraint, but the diff only shows a removal of a blank line. Please ensure that all intended changes are included in the commit. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_qWZlVi8l8NZwKU8P
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Remove Extra.forbid constraint. It is not really required and is too strict. additionally Enum forbid is not supported in pydantic >= 2.0 <= 2.9
Added test environment for pydantic 2.8 and 2.10 also
Important
Remove
Extra.forbidconstraint from Pydantic models and update test environments for Pydantic 2.8 and 2.10.Extra.forbidconstraint from Pydantic models incatalog.pyandmanifest.py.constants.pywhich definedExtraenum.tox.iniandgithub-actions.yml.github-actions.ymlto reflect new Pydantic versions.tox.iniandgithub-actions.yml.This description was created by
for 1514bf1. It will automatically update as commits are pushed.