Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add AHS Validation and create Emulators for AWS Devices that support the AHS DeviceActionType #4

Open
wants to merge 8 commits into
base: only_validation
Choose a base branch
from

Conversation

Altanali
Copy link
Owner

Issue #, if available:

Description of changes:

Support Emulation of AHS Programs and the creation of an AHS Emulator for AWS Devices that support the DeviceActionType.AHS action. Introduce Device specific AHS Program validation that extends the existing AHS program validator in the Default Simulator. Dependent on the following PR of the default simulator: amazon-braket/amazon-braket-default-simulator-python#272.

Testing done:
Unit tested of the modified AHS Program validators (DeviceAtomArrangment, DeviceLocalDetuning, DeviceDrivingField, DeviceHamiltonian and the extended AHS Program IR Validator. Tested creation of an AHS Emulator from a Quera Device Capabilities Object.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants