Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve activity - order of transactions #2192

Closed
AW-STJ opened this issue Oct 6, 2020 · 4 comments · Fixed by #2201
Closed

Improve activity - order of transactions #2192

AW-STJ opened this issue Oct 6, 2020 · 4 comments · Fixed by #2201
Assignees
@hboon
Labels
Bug Something isn't working

Comments

@AW-STJ
Copy link

AW-STJ commented Oct 6, 2020 •
edited
Loading

Maybe these will be addressed as part of activity work, however, wanted to point this out.

As I was doing more investigation for a transaction related issue reported by Android user, I found out that the transactions were not captured accurately.
AlphaWallet/alpha-wallet-android#1628

The most accurate transactions were captured by Zerion.
image

Also check out the order of xDAI transactions that I executed to test #2188

Please investigate why the order of the successful DAI transaction is different to others wallets. Let me know if we need more details.

Also it is not very evident that the transactions have been failed.

@colourfreak - can you review how Android displays failed transactions and confirm the designs so that we can align both Android and iOS to display failed transactions similarly.
@AW-STJ AW-STJ added the Bug Something isn't working label Oct 6, 2020
@AW-STJ AW-STJ changed the title Improve activity Improve activity - order of transactions and add trade transaction Oct 6, 2020
@AW-STJ AW-STJ changed the title Improve activity - order of transactions and add trade transaction Improve activity - order of transactions Oct 6, 2020
@hboon
Copy link
Member

hboon commented Oct 6, 2020

@AW-STJ can you paste the wallet address some where to check against?

@AW-STJ
Copy link
Author

AW-STJ commented Oct 6, 2020

There you go Boon, wallet address 0xfCABe3451aC8EDfB8FB6b9274C2E095D9cCC8082

@colourfreak
Copy link

There is another on with Contact Execution. Zerion does the work.

Screenshot 2020-10-07 at 09 07 24

Hash
https://etherscan.io/tx/0x98f65e2e737b69a42786a9abe2bba4a376a5390c9aca641900c991ca70f12f68

Application
0x4976fb03c32e5b8cfe2b6ccb31c09ba78ebaba41
2020-10-07 08 51 10

@hboon hboon mentioned this issue Oct 9, 2020
Merged
@hboon
Copy link
Member

hboon commented Oct 9, 2020

Fixed the error (including sort order) in #2192, but created an issue for display in SmartTokenLabs/TokenScript#393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hboon hboon

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@hboon @colourfreak @AW-STJ