Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting Contributors #188

Open
Almoullim opened this issue Jul 17, 2023 · 9 comments
Open

Requesting Contributors #188

Almoullim opened this issue Jul 17, 2023 · 9 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@Almoullim
Copy link
Owner

Due to lack of free time to continue to work on this at the moment. If anyone is willing to help keep this project alive, please let me know.

@Almoullim Almoullim added the help wanted Extra attention is needed label Jul 17, 2023
@Almoullim Almoullim self-assigned this Jul 17, 2023
@Almoullim Almoullim pinned this issue Jul 17, 2023
@MoralCode
Copy link
Collaborator

MoralCode commented Jul 17, 2023

What would you prefer to work on and what areas do you want extra help? I could probably continue to contribute some issue triage efforts to help reduce the number of open issues due to duplicates or resolved issues

@Almoullim
Copy link
Owner Author

Responding to issues, checking PR's and merging them etc., if possible and willing, attempting to fix issues would be a plus :) @MoralCode

@MoralCode
Copy link
Collaborator

sounds good! As i only briefly used this library, how much scrutiny should be given to PR's coming in/how much do you care about the risk of breaking something in prod?

  • is looking at the code sufficient?
  • is there a set of automated tests I can run to validate some functionality?
  • should I run the code/do I have to run the code on-device and check anything?

I'm happy to respond to incoming issues/PR's as they trickle in, but testing on device/trying to cover every scenario manually might slow down the merging of things substantially as Im no longer actively using this dependency in a project and dont have a ton of time to dedicate to testing

@MoralCode
Copy link
Collaborator

echoing my comments from the most recently mentioned PR here as well since they seem relevant:

At the current stage I'm sorta unsure what to do with the limited time that I have (see my comments above). The volume of conversation happening on issues and PRs on this repo makes me suspect there's a fairly large userbase of this library (since typically only a small minority ends up speaking up in issues and PRs like this), which makes me hesitant to blindly merge stuff for fear of breaking things.
However, since I don't really use this library anymore and a) don't really have a great testing setup that would allow me to efficiently validate PRs to the level of quality this community probably expects, and b) dont really have time, much like @Almoullim), I'm not really sure if I'm able to support this project in the ways that it needs.

If there were something like automated test cases that had good coverage or like a detailed/step by step testing methodology that interested community members could run and post comments verifying that it works for them, that would definitely give me more confidence that things aren't going to break by merging PRs, but as things stand now I'm not sure I can singlehandedly keep this project alive without someone else stepping up to help perform the bulk of the validation of incoming PRs

@MoralCode
Copy link
Collaborator

Some interesting comments (not mine) from #207 that may be relevant here:

In case this becomes maintained again, there may be a wa for it to differentiate itself in the community

there is simply no flutter package for geolocation which could handle background updates well

However, if not,

Maybe it's worth updating readme file and adding a note that the package isn't actively maintained and add a reference to #188

@BWMuller
Copy link
Contributor

@Almoullim @MoralCode I currently have an active project from 2021 that makes use of this library. Its primarily running from my own fork but I would be happy to assist where needed if it means updates and fixes are actively included here

@MoralCode
Copy link
Collaborator

@Almoullim @MoralCode I currently have an active project from 2021 that makes use of this library. Its primarily running from my own fork but I would be happy to assist where needed if it means updates and fixes are actively included here

That would be awesome! Do you think you would be willing to handle the bulk of the testing per some of my comments above?

That's really the biggest thing stopping me from feeling confident enough to merge things at this point. If someone with a stake in the functioning of this repo can validate PR's and say they are good to go and generally be the line of defense saying no to broken code, that would be super helpful.

Since I already have merge access (and some travel days coming up soon) I imagine we could get going relatively quickly and wouldn't need to wait for @Almoullim until there's a need to publish a release to pub.dev

What do you think?

@BWMuller
Copy link
Contributor

@MoralCode Sounds good to me. I'm going to see about setting up a base test that can also check if the app still runs in the end to make it easier

@MoralCode
Copy link
Collaborator

@MoralCode Sounds good to me. I'm going to see about setting up a base test that can also check if the app still runs in the end to make it easier

sounds good! any automation that can be done for testing, especially if they're runnable as GH Actions CI jobs, will make things so much smoother when reviewing PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants