Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using unavailable worker cached in client-pool to resolve #18693 #18694

Closed
wants to merge 0 commits into from

Conversation

yws-tracy
Copy link

@yws-tracy yws-tracy commented Sep 8, 2024

What changes are proposed in this pull request?

to fix #18693

Why are the changes needed?

In ClientPool, ClientPoolKey only takes ip into consideration, which is not enough, it can cause incorrect worker cache in clientPool. To fix the problem, hostName should be taken into consideration to compare ClientPoolKey as well

Does this PR introduce any user facing changes?

No

@alluxio-bot
Copy link
Contributor

Thank you for your pull request.
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement (CLA).
It's all electronic and will take just a few minutes. Please download CLA form here, sign, and e-mail back to [email protected]

@YichuanSun
Copy link
Contributor

Thanks for your pr! But are your sure you want to submit to main branch? If you want to fix the 2.x issue, please submit to master-2.x branch.

@yws-tracy
Copy link
Author

Thanks for your pr! But are your sure you want to submit to main branch? If you want to fix the 2.x issue, please submit to master-2.x branch.

Thanks for your reply, I think main branch still has the problem, and I will also submit to master-2.x branch.

@yws-tracy yws-tracy changed the base branch from main to master-2.x December 1, 2024 08:08
@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: PASS
  • Commits associated with Github account: FAIL
    • It looks like your commits can't be linked to a valid Github account.
      Your commits are made with the email [email protected], which does not allow your contribution to be tracked by Github.
      See this link for possible reasons this might be happening.
      To change the author email address that your most recent commit was made under, you can run:
      git -c user.name="Name" -c user.email="Email" commit --amend --reset-author
      See this answer for more details about how to change commit email addresses.
      Once the author email address has been updated, update the pull request by running:
      git push --force https://github.com/yws-tracy/alluxio.git optimize/ClientPoolKey

Some checks failed. Please fix the reported issues and reply
alluxio-bot, check this please
to re-run checks.

@yws-tracy yws-tracy changed the base branch from master-2.x to main December 1, 2024 08:09
@yws-tracy yws-tracy closed this Dec 1, 2024
@yws-tracy yws-tracy force-pushed the optimize/ClientPoolKey branch from 82b0601 to e1f4443 Compare December 1, 2024 08:20
@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: PASS
  • Commits associated with Github account: PASS

All checks passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix using unavailable worker cached in client-pool
3 participants