Add position read supports for s3 proxy #18578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackson-Wang-7
approved these changes
Apr 17, 2024
|
alluxio bot, merge this please |
|
merge failed: |
elega
added
the
type-performance
|
alluxio bot, merge this please |
|
alluxio-bot, cherry-pick this to branch-2.10 please |
alluxio-bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
### What changes are proposed in this pull request? When requesting a smaller range from the S3 proxy, support the S3 proxy in using the position read API to request data from the worker. add a new property: ``` alluxio.proxy.s3.use.position.read.range.size ``` ### Why are the changes needed? Using position read can effectively solve the issue of reading amplification. Please clarify why the changes are needed. For instance, 1. If you propose a new API, clarify the use case for a new API. no 2. If you fix a bug, describe the bug. no ### Does this PR introduce any user facing changes? Please list the user-facing changes introduced by your change, including 1. change in user-facing APIs no 2. addition or removal of property keys yes 3. webui no pr-link: #18578 change-id: cid-16bc766da5b13a1ca9acee4bea1151723a9f909d
|
Auto cherry-pick to branch |
alluxio-bot
added a commit
that referenced
this pull request
Apr 18, 2024
Cherry-pick of existing commit. orig-pr: #18578 orig-commit: e56de13 orig-commit-author: humengyu <[email protected]> pr-link: #18579 change-id: cid-16bc766da5b13a1ca9acee4bea1151723a9f909d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
When requesting a smaller range from the S3 proxy, support the S3 proxy in using the position read API to request data from the worker.
add a new property:
Why are the changes needed?
Using position read can effectively solve the issue of reading amplification.
Please clarify why the changes are needed. For instance,
Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including