Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local cache to catch 3.x #18574

Merged
merged 7 commits into from
Apr 26, 2024

Conversation

jja725
Copy link
Contributor

@jja725 jja725 commented Apr 11, 2024

What changes are proposed in this pull request?

cherry pick all local cache related stuff back to 2.x. The principle here is to keep Trino using the same code as 3.x

Why are the changes needed?

Please clarify why the changes are needed. For instance,

  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug.

Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including

  1. change in user-facing APIs
  2. addition or removal of property keys
  3. webui

@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: FAIL
    • The title of the PR does not pass all the checks. Please fix the following issues:
      • First word of title ("Cherry") is not an imperative verb. Please use one of the valid words
  • Commits associated with Github account: PASS

Some checks failed. Please fix the reported issues and reply
alluxio-bot, check this please
to re-run checks.

@jja725 jja725 changed the title Cherry pick local cache Update local cache to catch 3.x Apr 11, 2024
@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: PASS
  • Commits associated with Github account: PASS

All checks passed!

@jja725 jja725 force-pushed the cherry-pick-local-cache branch 5 times, most recently from 636b222 to 68bc2df Compare April 22, 2024 06:05
Copy link
Contributor

@JiamingMai JiamingMai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jja725
Copy link
Contributor Author

jja725 commented Apr 26, 2024

alluxio-bot, merge this please

@alluxio-bot
Copy link
Contributor

merge failed:
Merge refused because pull request does not have label start with type-

@jja725
Copy link
Contributor Author

jja725 commented Apr 26, 2024

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 3e520f1 into Alluxio:master-2.x Apr 26, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants