Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running on early-access JDK #18553

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Mar 19, 2024

What changes are proposed in this pull request?

Alluxio doesn't work with early-access (EA) JDKs which makes it hard to do some forward-testing before new JDK is released.

Why are the changes needed?

Please clarify why the changes are needed. For instance,

  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug.

Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including

  1. change in user-facing APIs
  2. addition or removal of property keys
  3. webui

@alluxio-bot
Copy link
Contributor

Thank you for your pull request.
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement (CLA).
It's all electronic and will take just a few minutes. Please download CLA form here, sign, and e-mail back to [email protected]

@wendigo
Copy link
Contributor Author

wendigo commented Mar 20, 2024

CLA signed.

Copy link
Contributor

@YichuanSun YichuanSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! LGTM

@wendigo
Copy link
Contributor Author

wendigo commented Mar 21, 2024

@alluxio-bot recheck

@wendigo
Copy link
Contributor Author

wendigo commented Mar 21, 2024

@YichuanSun thanks for the review!

@YichuanSun
Copy link
Contributor

alluxio-bot, merge this please.

@alluxio-bot
Copy link
Contributor

merge failed:
Merge refused because pull request does not have label start with type-

@YichuanSun YichuanSun added the type-bug This issue is about a bug label Mar 22, 2024
@YichuanSun
Copy link
Contributor

alluxio-bot, merge this please.

@alluxio-bot alluxio-bot merged commit aac8a61 into Alluxio:main Mar 22, 2024
12 checks passed
@wendigo wendigo deleted the serafin/jdk-ea branch March 28, 2024 15:40
@wendigo wendigo restored the serafin/jdk-ea branch March 28, 2024 15:40
@wendigo
Copy link
Contributor Author

wendigo commented Mar 28, 2024

@YichuanSun can you release new version? I'd like to start testing it with JDK 23-ea

@YichuanSun
Copy link
Contributor

@YichuanSun can you release new version? I'd like to start testing it with JDK 23-ea

I don't really understand. Do you mean creating a new branch like "Alluxio-x.x.x-for-your-test"?

@wendigo
Copy link
Contributor Author

wendigo commented Mar 29, 2024

I don't know how your automation works. I need 312 release

@YichuanSun
Copy link
Contributor

I'm more confused, what is 312? Alluxio 3.1.2? Or anything else?

@wendigo
Copy link
Contributor Author

wendigo commented Mar 29, 2024

image

Next version I suppose?

@wendigo
Copy link
Contributor Author

wendigo commented Mar 29, 2024

Trino is currently using version 311 from mvncentral: https://mvnrepository.com/artifact/org.alluxio/alluxio-core-common/311

@YichuanSun
Copy link
Contributor

I see. Sorry I don't have the right to do this.

@YichuanSun
Copy link
Contributor

Maybe you can find any help in our slack channel, version release is out of my scope, actually I don't know how to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug This issue is about a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants