-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the security vulnerability from jackcon databind #15665
Fix the security vulnerability from jackcon databind #15665
Conversation
this unit test failure looks real: |
Yes, looks like the behavior of null/empty values changed, from
|
I fix the test by adding So the result is changed from
to
The @ZhuTopher could you help take a look? thanks! |
@@ -24,6 +25,7 @@ | |||
*/ | |||
@JacksonXmlRootElement(localName = "CompleteMultipartUploadResult") | |||
@JsonPropertyOrder({ "Location", "Bucket", "Key", "ETag" }) | |||
@JsonInclude(JsonInclude.Include.NON_EMPTY) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the available fields for CompleteMultipartUpload
seem be fields which are intended to be empty strings, so I'm okay with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact <Code/>
and <Message/>
belong to error responses and not CompleteMultipartUpload
directly. Again, change should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ZhuTopher ! If you saw any abnormal ser/deser results of json or xml, just let me know, thx!
alluxio-bot, merge this please. |
What changes are proposed in this pull request?
fix https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-36518
Why are the changes needed?
jackson-databind before 2.13.0 allows a Java StackOverflow exception and denial of service via a large depth of nested objects.
Does this PR introduce any user facing changes?
no