Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: use -Werror #982

Merged
merged 1 commit into from
Feb 2, 2022
Merged

cleanup: use -Werror #982

merged 1 commit into from
Feb 2, 2022

Conversation

AndreasLMeg
Copy link
Collaborator

@AndreasLMeg AndreasLMeg commented Jan 29, 2022

With this flag all warning are changed into errors.
The main advantage is that the automatic test (action) now immediately alerts us to warnings
If warnings cannot be avoided, this can be switched off in the source code if necessary.

With this flas all warning are changed errors.
The main advantage is that the automatic test (action) now immediately alerts us to warnings
If warnings cannot be avoided, this can be switched off in the source code if necessary.
@EricClaeys
Copy link
Collaborator

@AndreasLMeg This will hide ALL warnings from ALL progams, not just sunwait, correct?
Is there a way to just do it for sunwait?

@AndreasLMeg
Copy link
Collaborator Author

@AndreasLMeg This will hide ALL warnings from ALL progams, not just sunwait, correct? Is there a way to just do it for sunwait?

-Werror - This will NOT hide the warnings.
It makes them even more annoying. (warning -> error)
That's why the developer has to make sure that no warnings get into the source code at all. A compulsion to do our job better.

@linuxkidd linuxkidd merged commit 8d2b8aa into master Feb 2, 2022
@EricClaeys EricClaeys deleted the AndreasLMeg-Werror branch February 10, 2022 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants