endOfNight.sh: aid in debugging #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add completion messages to log to make it easy to see when the commands finished.
|
Since you're doing this.. why not move the 'complete' statement to just below the generation, and add another inside the upload conditional saying |
|
@linuxkidd Michael, the reasons I was going to give for how I do it don't make sense after I looked at the code again, so I will change to how you suggested. Since almost all the issues users have are with the generation of those files and not uploading them, putting the 2nd message right after the generation will make it easier to find issues in the log file. |
Put the "completed" messages directly after the generation of the images. On upload, the upload script displays messages.
Dang it. I forgot to replace $? with $RET.
|
@linuxkidd Ready for review. |
AndreasLMeg
approved these changes
Jan 21, 2022
linuxkidd
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add completion messages to log to make it easy to see when the commands finished.