Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run custom script at end of night #270

Merged
merged 3 commits into from
Oct 6, 2020
Merged

Run custom script at end of night #270

merged 3 commits into from
Oct 6, 2020

Conversation

Alex-developer
Copy link
Collaborator

Allow a custom script to be run during the end of night processing. The script is run prior to the deletion in case you want to do something with the images before they are removed, as in my case where I am archiving them to a local ssd

Allow a custom script to be run during the end of night processing. The script is run prior to the deletion in case you want to do something with the images before they are removed, as in my case where I am archiving them to a local ssd
@thomasjacquin
Copy link
Collaborator

Hey Alex, I like having a place for custom code that's separate from the main logic. What about having an empty endOfNight_additionalSteps.sh? That way it wouldn't require any addition to the config file and would be less prone to a path error.
My thought here is to try to keep the config file quite general (options that most people want to use) and small enough to be readable.

@Alex-developer
Copy link
Collaborator Author

Thomas

Makes perfect sense :-) If people did want to keep the scripts outside of the allsky directory they could just call their script from the endOfNight_additionalSteps.sh.

I'll modify the pull request and add the additional script.

Alex added 2 commits October 5, 2020 22:37
Change the end of night additional script to be a fixed script rather than via the config
@thomasjacquin thomasjacquin merged commit 0aacf55 into AllskyTeam:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants