Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload.sh: restore line #1115

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Upload.sh: restore line #1115

merged 1 commit into from
Mar 31, 2022

Conversation

EricClaeys
Copy link
Collaborator

This line should never have been removed.

@EricClaeys
Upload.sh: restore line
5ab9d6b 
This line should never have been removed.
@EricClaeys EricClaeys added the bug Needs software change label Mar 31, 2022
@EricClaeys
Copy link
Collaborator Author

This bug breaks users that set the variable to resolve server certificate issues.

thomasjacquin
thomasjacquin approved these changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@thomasjacquin thomasjacquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bug seems like it could prevent users from uploading files. I believe it's a candidate for a hot-fix

@EricClaeys EricClaeys merged commit 4a7c5fa into master Mar 31, 2022
@EricClaeys EricClaeys deleted the EricClaeys-patch-1 branch April 2, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjacquin thomasjacquin thomasjacquin approved these changes

@AndreasLMeg AndreasLMeg Awaiting requested review from AndreasLMeg

@linuxkidd linuxkidd Awaiting requested review from linuxkidd

Assignees
No one assigned
Labels
bug Needs software change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EricClaeys @thomasjacquin