Eric Claeys' changes to allsky-website #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An image to be used when no thumbnail is found for archived timelapses. This replaces the aurora thumbnail. I discussed this with Thomas late July, 2021.
Use the image as a thumbnail if unable to create a thumbnail.
Use the image as a thumbnail if unable to create a thumbnail. Fixed issue where thumbnails were stretched horizontally on large screens.
If no thumbnail exists, it now displays an image that says there is no thumbnail, rather than displaying an aurora image. I discussed this with Thomas the end of July, 2021. Fixed issue where thumbnails were stretched horizontally on large screens. Removed duplicate image name code. Left in the legacy "onmouseenter" and "onmouseleave" code, but it's not used. Thomas can determine if it should be removed (remove $y and <script> block).
Removed "-resize" because the new allsky scripts (which will be submitted soon) no longer use that suffix. Added "showOverlayAtStartup" which displays the overlay when the page first loads, rather than requiring the user to click on the icon for it.
Uses config.showOverlayAtStartup
Checks if imagecreatefromjpeg() exists and displays an appropriate message if it doesn't, then returns false. Returns true if it could make the thumbnail.
Changed default imageName. Added showOverlayAtStartup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes discussed with Thomas the end of July, 2021, primarily related to creating and displaying thumbnails.