tests/test_nwb1_nwb2_conversion.py: Upgrade to newer pynwb versions #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pynwb versions since 6b2a628f (Hardcode units of PatchClampSeries subclasses (#1036), 2019-08-05) use fixed units for the patch clamp series derived classes. After changing that the tests pass again.
t-b
force-pushed
the
nwb-schema-2.2.1
branch
from
b04b1dc to
5f9fee7
Compare
|
@t-b The nwb1_to_nwb2 conversion is not being used. Instead we are using pxp to nwb2 conversion. Thus, it makes sense to remove the nwb1 to nwb2 coversion and corresponding test and close this PR. |
|
Close per #410 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pynwb versions since 6b2a628f (Hardcode units of PatchClampSeries
subclasses (#1036), 2019-08-05) use fixed units for the patch clamp
series derived classes.
After changing that the tests pass again.