Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLFW: after render is not called after render #345

Open
gucio321 opened this issue Oct 4, 2024 · 0 comments
Open

GLFW: after render is not called after render #345

gucio321 opened this issue Oct 4, 2024 · 0 comments

Comments

@gucio321
Copy link
Collaborator

gucio321 commented Oct 4, 2024

glfw_window_refresh_callback calls glfw_render, but does not call before/after render callbacks.

  • causes cleanState not called every frame in giu
  • causes widgetIndex not being cleaned
  • causes imageWithRgbaWidget creates multiple textures
  • causes programm crash when GC takes one of these textures

(will be hotfixed in giu now but should actually be fixed here)
gucio321 added a commit to gucio321/giu that referenced this issue Oct 4, 2024
@gucio321
mw: move steate clean/invalidation calls to the main render function
086e6bb 
reasons:
- due to a bug in cimgui-go (AllenDang/cimgui-go#345) before/after render callbacks are not called correctly
@gucio321 gucio321 mentioned this issue Oct 4, 2024
Closed
@gucio321 gucio321 mentioned this issue Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gucio321