Allow numpy array passed into autothresholding function #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughes036
reviewed
Dec 9, 2024
| image = image.detach().cpu().float().numpy() | ||
| # Only get numpy array from torch tensor if tensor is passed in | ||
| # Allows np.ndarray to be passed in directly | ||
| if not isinstance(image, np.ndarray): |
There was a problem hiding this comment.
Im not a fan of reassigning an arg (I know this was already happening before the change). Could you use a new local var?
| # Only get numpy array from torch tensor if tensor is passed in | ||
| # Allows np.ndarray to be passed in directly | ||
| if not isinstance(image, np.ndarray): | ||
| image = image.detach().cpu().float().numpy() |
There was a problem hiding this comment.
(feel free to ignore since this is out of the scope of the pr)
there's also a detach function that does the detach->cpu->numpy conversion, so this could be replaced with
img = detach(img).astype(float)
| image = image.detach().cpu().float().numpy() | ||
| # Only get numpy array from torch tensor if tensor is passed in | ||
| # Allows np.ndarray to be passed in directly | ||
| if not isinstance(image, np.ndarray): |
There was a problem hiding this comment.
(same as below) this might be better as if isinstance(image, torch.Tensor)
benjijamorris
approved these changes
Dec 9, 2024
hughes036
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows numpy arrays to be passed into the auththresholding function in
AutoThresh.pywhile still allowing torch tensors as before.Allows thresholding to work properly