Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add hyperlinks to directories and improve navigation #5178

Merged
merged 9 commits into from
Dec 1, 2024

Conversation

young010101
Copy link
Contributor

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions


Link of any specific issues this addresses

Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! A few comments.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@young010101 young010101 marked this pull request as draft November 22, 2024 01:22
@young010101 young010101 marked this pull request as ready for review November 22, 2024 01:24
@young010101 young010101 marked this pull request as draft November 22, 2024 01:24
@young010101
Copy link
Contributor Author

Thank you for the contribution! A few comments.

Thanks for the docs philosophy insight!

@young010101
Copy link
Contributor Author

@openhands-agent
Would ./tests/runtime be the right link for integration? If not, could you point me in the right direction? IMPORTANT: The only thing you need to do is adding the proper hyperlink for integration in CONTRIBUTING.md.

@enyst
Copy link
Collaborator

enyst commented Nov 27, 2024

@young010101 Sorry, if you want to see how fun openhands-agent is in real use, please take a look at this guide to set it up:
OpenHands Github Issue Resolver

It will work on your repositories, or repositories where you have permissions to push. For example, you can set it up and call it - like you did - on your repo https://github.com/young010101/OpenHands

@enyst
Copy link
Collaborator

enyst commented Nov 27, 2024

(Lets try with the label!)

Integration tests have been moved out of the tests directory in openhands repo. Find them and fix the CONTRIBUTING.md documentation as pointed out in comments above.

@enyst enyst added the fix-me Attempt to fix this issue with OpenHands label Nov 27, 2024
@enyst
Copy link
Collaborator

enyst commented Nov 27, 2024

It failed, lol. 🤔

I posted an issue on it: #5292

I suspect it failed because your branch is external to the repository (a fork) - for now, that doesn't seem to work.

Back to your question: integration tests were in the same place, indeed a part of /tests, but they have been rewritten and moved, and now they are here:
https://github.com/All-Hands-AI/OpenHands/tree/main/evaluation/integration_tests

@young010101
Copy link
Contributor Author

@young010101 Sorry, if you want to see how fun openhands-agent is in real use, please take a look at this guide to set it up: OpenHands Github Issue Resolver

It will work on your repositories, or repositories where you have permissions to push. For example, you can set it up and call it - like you did - on your repo https://github.com/young010101/OpenHands

Thank you for the clarification and the link to the guide. I'll review the setup steps and see how it works on my repository. Appreciate the guidance!

@young010101
Copy link
Contributor Author

young010101 commented Nov 27, 2024

It failed, lol. 🤔

I posted an issue on it: #5292

I suspect it failed because your branch is external to the repository (a fork) - for now, that doesn't seem to work.

Back to your question: integration tests were in the same place, indeed a part of /tests, but they have been rewritten and moved, and now they are here: https://github.com/All-Hands-AI/OpenHands/tree/main/evaluation/integration_tests

Thanks for identifying the issue and sharing the new location of the integration tests! I’ll adjust my branch accordingly. I also found the old tests in a previous commit: https://github.com/All-Hands-AI/OpenHands/tree/23d3becf1d6f5d07e592f7345750c314a826b4e9/tests/integration

@young010101 young010101 marked this pull request as ready for review November 27, 2024 16:58
Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@enyst enyst requested a review from neubig November 28, 2024 03:11
@neubig neubig merged commit eb5f4f5 into All-Hands-AI:main Dec 1, 2024
12 checks passed
@young010101 young010101 deleted the docs/add-hyperlinks branch December 2, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-me Attempt to fix this issue with OpenHands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants