feature: volume and mount propagation for cri manager #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YaoZengzeng <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #717 +/- ##
==========================================
- Coverage 10.9% 10.84% -0.07%
==========================================
Files 93 93
Lines 5482 5513 +31
==========================================
Hits 598 598
- Misses 4836 4867 +31
Partials 48 48
Continue to review full report at Codecov.
|
allencloud
reviewed
Feb 8, 2018
| @@ -829,6 +830,16 @@ func (mgr *ContainerManager) parseVolumes(ctx context.Context, c *types.Containe | |||
| } | |||
|
|
|||
| source = mountPath | |||
| } else { | |||
There was a problem hiding this comment.
func parseVolumes is not so good, and there are so much improvement we could do for it.
16 tasks
|
Could we add a test case in integration test for this case? |
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes part of #635
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
It has already passed the corresponding tests in cri-tools.
Ⅴ. Special notes for reviews