bugfix: make the output of some list operations optional #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaoZengzeng
changed the title
YaoZengzeng
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2158 +/- ##
=========================================
+ Coverage 64.16% 64.3% +0.13%
=========================================
Files 209 209
Lines 16713 16714 +1
=========================================
+ Hits 10724 10748 +24
+ Misses 4648 4634 -14
+ Partials 1341 1332 -9
|
allencloud
reviewed
Aug 27, 2018
cri/v1alpha1/cri_wrapper.go
Outdated
| logrus.Infof("success to ListPodSandbox: %+v", res.Items) | ||
| } | ||
| }() | ||
| if c.debug { |
There was a problem hiding this comment.
I do not think add c.debug is a good way. How about make logrus.Infof to be logrus.Debugf?
Signed-off-by: YaoZengzeng <[email protected]>
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng [email protected]
Ⅰ. Describe what this PR did
1
Kubelet will try to do list (sandbox, container, etc) operations every seconds,
So pouch will output so many logs corresponding to the list operations
which is usually verbose and useless
So this PR make pouch only output the log of list operations when in debug mode.
2
Also change some error log to warning log which make pouch work well in Alibaba
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
No
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews