feature: update the version of cri-o/ocicni #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starnop
force-pushed
the
ocicni-update
branch
4 times, most recently
from
164cdc6 to
42a3b5b
Compare
Signed-off-by: Starnop <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2065 +/- ##
==========================================
- Coverage 63.8% 63.79% -0.01%
==========================================
Files 202 202
Lines 15621 15621
==========================================
- Hits 9967 9966 -1
- Misses 4413 4415 +2
+ Partials 1241 1240 -1
|
|
Please add more reasons about why we need to update the vendored package. For example, the newer version has fixed some certain bugs and so on. 😄 @starnop |
YaoZengzeng
changed the title
|
@starnop Please remove |
starnop
changed the title
|
@YaoZengzeng Has been well tested. ：) |
|
LGTM |
|
ping @starnop |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Starnop [email protected]
Ⅰ. Describe what this PR did
update the version of cri-o/ocicni
Now that
watcheris running and watching thepluginDirgather the initial configuration, before starting the goroutine which will actually process events. It has to be done in this order to avoid missing any updates which might otherwise occur between gathering the initial configuration and starting the watcher.Ⅱ. Does this pull request fix one issue?
None.
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews