Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: check image parsed error #1754

Closed
wants to merge 1 commit into from

Conversation

oiooj
Copy link
Contributor

@oiooj oiooj commented Jul 19, 2018

Fix #1748 and add a test.

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Jul 19, 2018
@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @oiooj
While we thought PR Description could be more specific, longer than 100 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@pouchrobot
Copy link
Collaborator

@oiooj Thanks for your contribution. 🍻
Please sign off in each of your commits.

@oiooj
Copy link
Contributor Author

oiooj commented Jul 19, 2018

In favor of #1753

@oiooj oiooj closed this Jul 19, 2018
@oiooj oiooj deleted the pr-pull-panic branch July 19, 2018 17:01
@codecov-io
Copy link

Codecov Report

Merging #1754 into master will decrease coverage by 2.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1754      +/-   ##
==========================================
- Coverage   14.16%   11.44%   -2.72%     
==========================================
  Files         281      197      -84     
  Lines       56797    53878    -2919     
==========================================
- Hits         8043     6167    -1876     
+ Misses      47817    46779    -1038     
+ Partials      937      932       -5
Impacted Files Coverage Δ
apis/opts/sysctl.go 0% <0%> (-100%) ⬇️
apis/opts/shm_size.go 0% <0%> (-100%) ⬇️
apis/opts/memory_swappiness.go 0% <0%> (-100%) ⬇️
apis/opts/oom_score.go 0% <0%> (-100%) ⬇️
apis/opts/memory.go 0% <0%> (-100%) ⬇️
pkg/net/interface.go 0% <0%> (-89.07%) ⬇️
apis/opts/diskquota.go 0% <0%> (-87.5%) ⬇️
pkg/multierror/def.go 15.38% <0%> (-84.62%) ⬇️
apis/opts/memory_swap.go 0% <0%> (-81.82%) ⬇️
daemon/logger/loggerutils/tag.go 0% <0%> (-81.82%) ⬇️
... and 131 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants