Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add more test for container operations #1457

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

ZouRui89
Copy link
Contributor

@ZouRui89 ZouRui89 commented Jun 3, 2018

Signed-off-by: Zou Rui [email protected]

Ⅰ. Describe what this PR did

This pr adds the rest of mock test except the one for log.

Ⅱ. Does this pull request fix one issue?

fixes #966

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Right now, the log command is still WIP.

So, @fuweid will finish the mock test for log in his patch. And when his pr is merged, the work for all the mock test will be done.

@allencloud
Copy link
Collaborator

Unit test in CI fails, see:

--- FAIL: TestContainerAttachError (0.00s)
	container_attach_test.go:20: expected a Server Error, got dial: unknown network 
--- FAIL: TestContainerAttach (0.00s)
	container_attach_test.go:43: dial: unknown network 
--- FAIL: TestContainerCreateExec (0.00s)
	container_exec_test.go:53: failed to decode body: EOF
--- FAIL: TestContainerStartExecError (0.00s)
	container_exec_test.go:64: expected a Server Error, got dial: unknown network 
--- FAIL: TestContainerStartExec (0.00s)
	container_exec_test.go:93: dial: unknown network

@ZouRui89

@allencloud
Copy link
Collaborator

Any update on this? @ZouRui89

@ZouRui89 ZouRui89 force-pushed the mock branch 5 times, most recently from 27ab61c to 15f6d19 Compare June 7, 2018 07:32
@codecov-io
Copy link

Codecov Report

Merging #1457 into master will increase coverage by 24.24%.
The diff coverage is 43.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1457       +/-   ##
===========================================
+ Coverage    16.3%   40.54%   +24.24%     
===========================================
  Files         208      253       +45     
  Lines       13883    16466     +2583     
===========================================
+ Hits         2263     6676     +4413     
+ Misses      11464     8936     -2528     
- Partials      156      854      +698
Impacted Files Coverage Δ
client/container_logs.go 0% <ø> (ø)
client/container_attach.go 0% <0%> (ø)
client/container_upgrade.go 100% <100%> (ø)
daemon/logger/jsonfile/utils.go 70% <0%> (ø) ⬆️
storage/volume/error/errors.go 28.57% <0%> (ø)
cri/stream/remotecommand/attach.go 0% <0%> (ø)
storage/quota/grpquota.go 0% <0%> (ø)
cri/stream/httpstream/httpstream.go 0% <0%> (ø)
pkg/term/term.go 0% <0%> (ø)
... and 119 more

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jun 7, 2018
@allencloud allencloud merged commit 77d19ed into AliyunContainerService:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test] add mock test for client package
4 participants