bugfix: refactor io to avoid output leak in execsync of cri #1388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng [email protected]
Ⅰ. Describe what this PR did
Now pouch will close and remove all the IO when exec finished.
Actually it will lead to a tricky bug.
Because there are so many levels of buffer in the path of exec. So when exec finished, some output of the exec may still be in one of the middle buffer. And if IO is closed now, we won't be able to get them.
This is why some of the CRI CI test case failed sometimes.
So we should let IO close itself other than triggered by the signal that exec finished.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
The IO path as follows:
fifo -> ring buffer -> backend
Before this PR, when exec finished, it will close IO including close ring and backend, but there may be still some data left in the fifo or ring.
So what this PR do is : the close of ring buffer is triggered by the data copying between fifo and ring.
And when the exec finished , it will close IO which include waiting for the ring to flush the data to the backend and finally close the backend.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews