Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the output file is used incorrectly & fix the wrong test case name #1258

Merged
merged 1 commit into from
May 2, 2018
Merged

bugfix: fix the output file is used incorrectly & fix the wrong test case name #1258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/exec/exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func (p *Process) Start() error {
err error
)
if p.Output != "" {
if file, err = os.OpenFile(p.Path, os.O_CREATE|os.O_APPEND|os.O_RDWR, 0666); err != nil {
if file, err = os.OpenFile(p.Output, os.O_CREATE|os.O_APPEND|os.O_RDWR, 0666); err != nil {
return errors.Wrap(err, "failed to open file")
}
p.file = file
Expand Down
2 changes: 1 addition & 1 deletion pkg/utils/utils_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ func TestDeDuplicate(t *testing.T) {
want: []string{"asdfgh01", "asdfgh02", "asdfgh03", "asdfgh04"},
},
{
name: "case with no duplicated",
name: "case with two duplicated",
args: args{
input: []string{"asdfgh01", "asdfgh02", "asdfgh01"},
},
Expand Down