Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add volume driver alias #1224

Merged
merged 1 commit into from
Apr 26, 2018

Conversation

rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented Apr 26, 2018

Ⅰ. Describe what this PR did

Add volume driver alias, pouchd can config the exist volume driver's
alias.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Rudy Zhang [email protected]

Add volume driver alias, pouchd can config the exist volume driver's
alias.

Signed-off-by: Rudy Zhang <[email protected]>
@HusterWan
Copy link
Contributor

We may need some test case in daemon to verify Volume Driver alias name feature @rudyfly

@codecov-io
Copy link

Codecov Report

Merging #1224 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1224   +/-   ##
=======================================
  Coverage   15.44%   15.44%           
=======================================
  Files         171      171           
  Lines       10576    10576           
=======================================
  Hits         1633     1633           
  Misses       8823     8823           
  Partials      120      120
Impacted Files Coverage Δ
daemon/config/config.go 10% <ø> (ø) ⬆️

@HusterWan
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 26, 2018
@HusterWan HusterWan merged commit dd5bda9 into AliyunContainerService:master Apr 26, 2018
@rudyfly rudyfly deleted the volume-alias branch May 4, 2018 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/storage kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants