Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: remove the DiskQuota useless field from Resource #1212

Merged
merged 1 commit into from
Apr 25, 2018
Merged

bugfix: remove the DiskQuota useless field from Resource #1212

merged 1 commit into from
Apr 25, 2018

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Apr 25, 2018

Signed-off-by: Wei Fu [email protected]

Ⅰ. Describe what this PR did

Remove the DiskQuota useless field from Resource

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

None

Ⅳ. Describe how to verify it

None

Ⅴ. Special notes for reviews

None

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Apr 25, 2018
@fuweid fuweid requested review from rudyfly and Letty5411 April 25, 2018 07:15
@codecov-io
Copy link

Codecov Report

Merging #1212 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1212      +/-   ##
==========================================
+ Coverage   15.57%   15.59%   +0.01%     
==========================================
  Files         178      178              
  Lines       10454    10441      -13     
==========================================
  Hits         1628     1628              
+ Misses       8706     8693      -13     
  Partials      120      120
Impacted Files Coverage Δ
daemon/mgr/container.go 0% <0%> (ø) ⬆️

@rudyfly
Copy link
Collaborator

rudyfly commented Apr 25, 2018

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 25, 2018
@rudyfly rudyfly merged commit 6c5b8bd into AliyunContainerService:master Apr 25, 2018
@fuweid fuweid deleted the bugfix_remove_useless_field_in_container_config branch April 25, 2018 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants