bugfix: pouch pull should handle space input as an error (#1753)

Signed-off-by: xiechengsheng <[email protected]>
AliyunContainerService · Jul 20, 2018 · 13667d3 · 13667d3
1 parent 56dd0f5
commit 13667d3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/cli/pull.go b/cli/pull.go
@@ -204,7 +204,11 @@ func pullMissingImage(ctx context.Context, apiClient client.CommonAPIClient, ima
 		}
 	}
 
-	namedRef, _ := reference.Parse(image)
+	namedRef, err := reference.Parse(image)
+	if err != nil {
+		return err
+	}
+
 	namedRef = reference.TrimTagForDigest(reference.WithDefaultTagIfMissing(namedRef))
 
 	var name, tag string

diff --git a/pkg/reference/parse_test.go b/pkg/reference/parse_test.go
@@ -126,6 +126,11 @@ func TestParse(t *testing.T) {
 				tag:   "1669a6aa7350e1cdd28f972ddad5aceba2912f589f19a090ac",
 			},
 			err: nil,
+		}, {
+			name:     "Contains space input",
+			input:    "  ",
+			expected: nil,
+			err:      ErrInvalid,
 		},
 	} {
 		ref, err := Parse(tc.input)