Table padding option #130

theSage21 · 2016-05-28T08:56:46Z

Cell padding in Tables is added as an option to maintain backward compatibility. Solves #125

coveralls · 2016-05-28T09:00:01Z

Coverage increased (+0.2%) to 97.143% when pulling ff58b47 on theSage21:master into 3950277 on Alir3z4:master.

theSage21 · 2016-05-28T09:01:54Z

@Alir3z4 Could you squash and pull this one? I am unable to do so.

Alir3z4 · 2016-05-28T09:43:04Z

Sure, I'll look into it and review it as well.
On May 28, 2016 1:01 PM, "arjoonn sharma" [email protected] wrote:

@Alir3z4 https://github.com/Alir3z4 Could you squash and pull this one?
I am unable to do so.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#130 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAkFCQ9NVedyOreChDOA867nDS-qvaaHks5qGASCgaJpZM4IpCBJ
.

Changaco · 2016-05-28T10:09:39Z

Merely looking for | in a line doesn't seem to me like a robust way to detect tables in a markdown document. I think you should wrap the tables with an HTML tag when padding is enabled, so that you'll have a clear marker to look for in the post-processing step.

Alir3z4 · 2016-05-28T10:47:37Z

html2text/utils.py

+    max_width = [len(x.rstrip()) + right_margin for x in lines[0].split('|')]
+    for line in lines:
+        cols = [x.rstrip() for x in line.split('|')]
+        max_width = [max(len(x) + right_margin, old_len) for x, old_len in zip(cols, max_width)]


pep8 please ;)
I'll be setting up some code quality checkers and linters

Hmm. For some reason my vim config of flake8 did not pick up any faults. Could you point out the changes I need to make?

No problem, leave it out.
We still don't have strict rules for pep8 or code quality.
We'll be cleaning them with #131

Alir3z4 · 2016-05-28T10:50:29Z

@theSage21 I agree with @Changaco about tagging the output for post-processing formatting, there might be places where it will fail to find the correct | also when you have tagged, I don't think that might be much of performance.

Changaco · 2016-05-28T10:55:13Z

test/pad_table.md

+Header 1  | Header 2  | Header 3                                     
+----------|-----------|----------------------------------------------
+Content 1 | Content 2 | ![200](http://lorempixel.com/200/200) Image! 
+Content 1 | Content 2 | ![200](http://lorempixel.com/200/200) Image! 


I suggest varying the content of the first two columns a little so we can better see padding in action.

Sounds good. I essentially copied the google_doc_tables test case and derived from there. I'm pushing this.

coveralls · 2016-05-28T11:51:40Z

Coverage increased (+0.2%) to 97.143% when pulling 0a7bdb5 on theSage21:master into 3950277 on Alir3z4:master.

coveralls · 2016-05-28T13:20:15Z

Coverage increased (+0.2%) to 97.163% when pulling f84b591 on theSage21:master into 3950277 on Alir3z4:master.

theSage21 · 2016-05-29T07:18:15Z

@Alir3z4 I think almost everything is fixed now. Squash and pull now?

Alir3z4 · 2016-05-29T09:27:38Z

Has the read me and docs has been updated with new changes in this pull
request? Readme.md, usage.md, other docs
On May 29, 2016 11:18 AM, "arjoonn sharma" [email protected] wrote:

@Alir3z4 https://github.com/Alir3z4 I think almost everything is fixed
now. Squash and pull now?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#130 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAkFCSNvi4pTDaDc_kaITGd_BIjR04F-ks5qGT23gaJpZM4IpCBJ
.

theSage21 · 2016-05-29T10:27:27Z

Ah, completely forgot about those. My bad. Adding them in.

- Add to usage

coveralls · 2016-05-29T10:32:02Z

Coverage increased (+0.2%) to 97.163% when pulling e1872ba on theSage21:master into 3950277 on Alir3z4:master.

Alir3z4 · 2016-05-29T10:51:38Z

If things are done, lemme know so I can merge in.

theSage21 · 2016-05-29T11:38:34Z

As far as I can see, everything is done. Please Squash and merge.

Alir3z4 · 2016-05-29T11:53:46Z

Great work everybody.
This is indeed very nice and beautiful.

The pull request is in the master and I'll be releasing a new release soon.

theSage21 · 2016-05-29T11:55:17Z

Would have been nice if you would have squashed it first. I made a mess out of the commits.

Alir3z4 · 2016-05-29T11:56:22Z

It has been squashed already, isn't ?
On May 29, 2016 3:55 PM, "arjoonn sharma" [email protected] wrote:

Would have been nice if you would have squashed it first. I made a mess
out of the commits.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#130 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAkFCdNzSPqPkaT4PDBSoOBNnxtBVyotks5qGX6mgaJpZM4IpCBJ
.

theSage21 · 2016-05-29T12:01:11Z

Hmm, I don't know. All those dirty commits still appear in the history https://github.com/Alir3z4/html2text/commits/master

Alir3z4 · 2016-05-29T12:30:11Z

@theSage21 Those commits are from yesterday that you pushed directly to master or from another pull request your merged I think, this is the squahed/merged commit df1d723

theSage21 · 2016-05-29T12:31:58Z

Hmm. Right. My mistake. I need sleep it seems.

On Sun, May 29, 2016 at 6:00 PM, Alireza Savand [email protected]
wrote:

@theSage21 https://github.com/theSage21 Those commits are from
yesterday that you pushed directly to master or from another pull request
your merged I think, this is the squahed/merged commit df1d723
df1d723

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#130 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AHVj0ZKwdb2hEwId_mv1uDByo1dry7CMks5qGYbUgaJpZM4IpCBJ
.

Changaco · 2016-05-29T12:45:34Z

!m @theSage21 @Alir3z4 :-)

To thank you for your work I've set up small donation pledges for you on Liberapay (a new open source recurrent donations platform I created). ;-)

theSage21 · 2016-05-29T12:47:37Z

@Changaco appreciate it. 😄

Alir3z4 · 2016-05-29T16:07:22Z

@Changaco Thank you, you're a great man.
I appreciate what you do and what you have done on Liberapay. I've been following it for a while and liked how/why it started. Wanted to help on its development but wasn't familiar with the work flow (I'm a Django or Flask or Klein developer aka lazy in development).

Again thank you for your great work.

Alir3z4 · 2016-05-29T16:24:59Z

@theSage21 @Changaco Just released a new version:
https://pypi.python.org/pypi/html2text/2016.5.29

Changaco · 2016-05-30T09:12:39Z

:-)

@Alir3z4 We explain a few things about our code in the README, but it's true that we have a web framework problem. We're working on cleaning up Aspen, but you know how it is: so many things to do, so little time. ;-)

theSage21 added 11 commits May 28, 2016 13:45

Pad tables CLI option

7569dfb

Pad tables option in parser

e714f1f

Pad table utility functions

b68c9bb

PAD_TABLES default is off

b4b7634

added tests

442c65d

Changelog update

01cf8ae

Fixed set definition for backward compatibility

a914186

Fixed set definition for backward compatibility

bbe01a7

Merge branch 'master' of github.com:theSage21/html2text

2aafc23

Add pad_table flag to test runner

75030ea

Remove table marker regex

ff58b47

Alir3z4 reviewed May 28, 2016
View reviewed changes

Alir3z4 self-assigned this May 28, 2016

Changaco reviewed May 28, 2016
View reviewed changes

Test shows off the padding

0a7bdb5

theSage21 added 3 commits May 28, 2016 18:43

More varied tests

5c57c26

Tag based table detection

1b78d10

reformatting adds space after table.

f84b591

- change pad_tables to pad-tables in the cli option

e1872ba

- Add to usage

Alir3z4 merged commit df1d723 into Alir3z4:master May 29, 2016

Changaco mentioned this pull request May 29, 2016

Watercooler - May 2016 liberapay/salon#36

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Table padding option #130

Table padding option #130

theSage21 commented May 28, 2016

coveralls commented May 28, 2016 •

edited

Loading

theSage21 commented May 28, 2016

Alir3z4 commented May 28, 2016

Changaco commented May 28, 2016

Alir3z4 May 28, 2016

theSage21 May 28, 2016

Alir3z4 May 28, 2016

Alir3z4 commented May 28, 2016

Changaco May 28, 2016

theSage21 May 28, 2016

coveralls commented May 28, 2016 •

edited

Loading

coveralls commented May 28, 2016 •

edited

Loading

theSage21 commented May 29, 2016

Alir3z4 commented May 29, 2016 •

edited

Loading

theSage21 commented May 29, 2016

coveralls commented May 29, 2016 •

edited

Loading

Alir3z4 commented May 29, 2016

theSage21 commented May 29, 2016

Alir3z4 commented May 29, 2016

theSage21 commented May 29, 2016

Alir3z4 commented May 29, 2016

theSage21 commented May 29, 2016

Alir3z4 commented May 29, 2016

theSage21 commented May 29, 2016

Changaco commented May 29, 2016

theSage21 commented May 29, 2016

Alir3z4 commented May 29, 2016

Alir3z4 commented May 29, 2016

Changaco commented May 30, 2016

Table padding option #130

Table padding option #130

Conversation

theSage21 commented May 28, 2016

coveralls commented May 28, 2016 • edited Loading

theSage21 commented May 28, 2016

Alir3z4 commented May 28, 2016

Changaco commented May 28, 2016

Alir3z4 May 28, 2016

Choose a reason for hiding this comment

theSage21 May 28, 2016

Choose a reason for hiding this comment

Alir3z4 May 28, 2016

Choose a reason for hiding this comment

Alir3z4 commented May 28, 2016

Changaco May 28, 2016

Choose a reason for hiding this comment

theSage21 May 28, 2016

Choose a reason for hiding this comment

coveralls commented May 28, 2016 • edited Loading

coveralls commented May 28, 2016 • edited Loading

theSage21 commented May 29, 2016

Alir3z4 commented May 29, 2016 • edited Loading

theSage21 commented May 29, 2016

coveralls commented May 29, 2016 • edited Loading

Alir3z4 commented May 29, 2016

theSage21 commented May 29, 2016

Alir3z4 commented May 29, 2016

theSage21 commented May 29, 2016

Alir3z4 commented May 29, 2016

theSage21 commented May 29, 2016

Alir3z4 commented May 29, 2016

theSage21 commented May 29, 2016

Changaco commented May 29, 2016

theSage21 commented May 29, 2016

Alir3z4 commented May 29, 2016

Alir3z4 commented May 29, 2016

Changaco commented May 30, 2016

coveralls commented May 28, 2016 •

edited

Loading

coveralls commented May 28, 2016 •

edited

Loading

coveralls commented May 28, 2016 •

edited

Loading

Alir3z4 commented May 29, 2016 •

edited

Loading

coveralls commented May 29, 2016 •

edited

Loading