[PWGHF] Omegac0/Xi pT cut #8962
Open
+48
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FDUEnrich
requested review from
alibuild,
vkucera,
fcolamar,
fgrosa,
fcatalan92,
mfaggin,
mmazzilli,
deepathoms,
NicoleBastid,
hahassan7,
jpxrk and
apalasciano
as code owners
[PWGHF] Please consider the following formatting changes to AliceO2Group#8962
fgrosa
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Hi @FDUEnrich thanks! The PR looks ok to me in general, I just have a few minor comments (see below)
Comment on lines
3238
to
3242
| // a tolerance has been added to be more conservative ptMinOmegaczeroToOmegaKaLfCasc ptMinXicZeroOmegacZeroToXiPiLfCasc | ||
| Configurable<float> ptMinOmegacZeroToOmegaPiLfCasc{"ptMinOmegacZeroToOmegaPiLfCasc", 2.0, "min. pT for Omegaczero in Omega + Pi decays"}; | ||
| Configurable<float> ptMinOmegaczeroToOmegaKaLfCasc{"ptMinOmegaczeroToOmegaKaLfCasc", 2.0, "min. pT for Omegaczero in Omega + Ka decays"}; | ||
| Configurable<float> ptMinXicZeroOmegacZeroToXiPiLfCasc{"ptMinXicZeroOmegacZeroToXiPiLfCasc", 2.0, "min. pT for XicZeroOmegacZero in Xi + Pi decays"}; | ||
| Configurable<float> ptMinXicplusLfCasc{"ptMinXicplusLfCasc", 2.0, "min. pT for Xicplus in Xi + Pi + Pi decays"}; |
There was a problem hiding this comment.
I would put 0 as default not to change the behaviour of pp wagons
Suggested change
| // a tolerance has been added to be more conservative ptMinOmegaczeroToOmegaKaLfCasc ptMinXicZeroOmegacZeroToXiPiLfCasc | |
| Configurable<float> ptMinOmegacZeroToOmegaPiLfCasc{"ptMinOmegacZeroToOmegaPiLfCasc", 2.0, "min. pT for Omegaczero in Omega + Pi decays"}; | |
| Configurable<float> ptMinOmegaczeroToOmegaKaLfCasc{"ptMinOmegaczeroToOmegaKaLfCasc", 2.0, "min. pT for Omegaczero in Omega + Ka decays"}; | |
| Configurable<float> ptMinXicZeroOmegacZeroToXiPiLfCasc{"ptMinXicZeroOmegacZeroToXiPiLfCasc", 2.0, "min. pT for XicZeroOmegacZero in Xi + Pi decays"}; | |
| Configurable<float> ptMinXicplusLfCasc{"ptMinXicplusLfCasc", 2.0, "min. pT for Xicplus in Xi + Pi + Pi decays"}; | |
| // a tolerance has been added to be more conservative ptMinOmegaczeroToOmegaKaLfCasc ptMinXicZeroOmegacZeroToXiPiLfCasc | |
| Configurable<float> ptMinOmegacZeroToOmegaPiLfCasc{"ptMinOmegacZeroToOmegaPiLfCasc", 0.f, "min. pT for Omegaczero in Omega + Pi decays"}; | |
| Configurable<float> ptMinOmegaczeroToOmegaKaLfCasc{"ptMinOmegaczeroToOmegaKaLfCasc", 0.f, "min. pT for Omegaczero in Omega + Ka decays"}; | |
| Configurable<float> ptMinXicZeroOmegacZeroToXiPiLfCasc{"ptMinXicZeroOmegacZeroToXiPiLfCasc", 0.f, "min. pT for XicZeroOmegacZero in Xi + Pi decays"}; | |
| Configurable<float> ptMinXicplusLfCasc{"ptMinXicplusLfCasc", 0.f, "min. pT for Xicplus in Xi + Pi + Pi decays"}; |
[PWGHF] Please consider the following formatting changes to AliceO2Group#8975
vkucera
reviewed
Dec 13, 2024
| @@ -3234,7 +3235,11 @@ struct HfTrackIndexSkimCreatorLfCascades { | |||
| // Selection criteria | |||
| // selections have been set to run2 lambda dedicated cuts | |||
| // selections for cascade have been set to the loosest value between xi and omega | |||
| // a tolerance has been added to be more conservative | |||
| // a tolerance has been added to be more conservative ptMinOmegaczeroToOmegaKaLfCasc ptMinXicZeroOmegacZeroToXiPiLfCasc | |||
There was a problem hiding this comment.
Why did you add ptMinOmegaczeroToOmegaKaLfCasc ptMinXicZeroOmegacZeroToXiPiLfCasc here?
There was a problem hiding this comment.
Dear expert, thank you for comment! I added these four configurable because Fabrizio suggested doing this. We think it's better to cut pT for OmegaczeroToOmegaKa, XicZeroOmegacZeroToXiPi, OmegacZeroToOmegaPi and XicplusToXiPiPi respectively.
There was a problem hiding this comment.
@vkucera this is for the production of derived data in Pb-Pb, for which it is unlikely that we can perform measurements to pT=0 and the size is drastically reduced if we skip the low pT
There was a problem hiding this comment.
@FDUEnrich @fgrosa I was referring to that very line with the comment.
[PWGHF] Please consider the following formatting changes to AliceO2Group#8962
fgrosa
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculating pT of Omegac0/Xi and cut pT< setting value. Fill after pTcut distribution histos and pTcut status.