[PWGLF] Update Histograms for lambda1520 task #8844

hkoley · 2024-12-06T09:21:31Z

Update Histograms:

Updated some histograms from TH3F to THnSparseF
Updated some histogram binning

Update Histograms: Updated some histograms from TH3F to THnSparseF Updated some histogram binning

BongHwi · 2024-12-06T09:26:54Z

Hello @hkoley , as suggested by O2linter, could you update the task to use std::abs for both TMath part and without prefix part?

alibuild · 2024-12-07T13:27:41Z

Error while checking build/O2Physics/o2 for 1f6f327 at 2024-12-13 03:37:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:995:18: error: 'lambda1520analysis' was not declared in this scope; did you mean 'Lambda1520analysis'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:995:18: error: 'lambda1520analysis' was not declared in this scope; did you mean 'Lambda1520analysis'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:995:3: error: missing template arguments before '{' token
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:1004:18: error: 'lambda1520analysis' was not declared in this scope; did you mean 'Lambda1520analysis'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:1004:18: error: 'lambda1520analysis' was not declared in this scope; did you mean 'Lambda1520analysis'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:1004:3: error: missing template arguments before '{' token
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:1051:18: error: 'lambda1520analysis' was not declared in this scope; did you mean 'Lambda1520analysis'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:1051:18: error: 'lambda1520analysis' was not declared in this scope; did you mean 'Lambda1520analysis'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:1051:3: error: missing template arguments before '{' token
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:1067:18: error: 'lambda1520analysis' was not declared in this scope; did you mean 'Lambda1520analysis'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:1067:18: error: 'lambda1520analysis' was not declared in this scope; did you mean 'Lambda1520analysis'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:1067:3: error: missing template arguments before '{' token
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:995:18: error: 'lambda1520analysis' was not declared in this scope; did you mean 'Lambda1520analysis'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:995:3: error: missing template arguments before '{' token
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:1004:18: error: 'lambda1520analysis' was not declared in this scope; did you mean 'Lambda1520analysis'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:1004:3: error: missing template arguments before '{' token
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:1051:18: error: 'lambda1520analysis' was not declared in this scope; did you mean 'Lambda1520analysis'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:1051:3: error: missing template arguments before '{' token
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:1067:18: error: 'lambda1520analysis' was not declared in this scope; did you mean 'Lambda1520analysis'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:1067:3: error: missing template arguments before '{' token
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:266:11: error: 'IsCalcRotBkg' was not declared in this scope; did you mean 'isCalcRotBkg'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:395:9: error: 'tof_at_high_pt' was not declared in this scope; did you mean 'tofAtHighPt'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:447:9: error: 'tof_at_high_pt' was not declared in this scope; did you mean 'tofAtHighPt'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:681:44: error: 'OccupancyCut' was not declared in this scope; did you mean 'occupancyCut'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:742:35: error: 'Pi' is not a member of 'std'
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:742:53: error: 'Pi' is not a member of 'std'
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:785:34: error: 'FixedPIDcut' was not declared in this scope; did you mean 'fixedPIDcut'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:881:15: error: 'IsCalcRotBkg' was not declared in this scope; did you mean 'isCalcRotBkg'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:883:47: error: 'Pi' is not a member of 'std'
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:883:59: error: 'Pi' is not a member of 'std'
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:883:86: error: 'Pi' is not a member of 'std'
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:883:98: error: 'Pi' is not a member of 'std'
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:1058:36: error: 'CfgVtxBins' was not declared in this scope; did you mean 'cfgVtxBins'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:1058:48: error: 'CfgMultBins' was not declared in this scope; did you mean 'cfgMultBins'?
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:1058:66: error: no matching function for call to 'o2::framework::ColumnBinningPolicy<o2::aod::collision::PosZ, o2::aod::resocollision::Cent>::ColumnBinningPolicy(<brace-enclosed initializer list>)'
/sw/slc9_x86-64/O2/daily-20241213-0000-local1/include/Framework/StructToTuple.h:141:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v13.2.0-alice1-3/include/c++/13.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(Lambda1520analysis*&)'
ninja: build stopped: subcommand failed.

Full log here.

hkoley · 2025-01-12T02:27:42Z

Hi @njacazio, could you please approve this PR?

alibuild · 2025-01-12T16:25:20Z

Error while checking build/O2Physics/o2 for 16b13f4 at 2025-01-12 17:25:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:102:78: error: expected '}' before string constant
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:102:78: error: could not convert '{"protonTPCPIDcuts", {3}}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<std::vector<double> >'
/sw/SOURCES/O2Physics/8844-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysis.cxx:102:78: error: expected ';' before string constant
/sw/slc9_x86-64/O2/daily-20250112-0000-local1/include/Framework/StructToTuple.h:141:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v13.2.0-alice1-3/include/c++/13.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(Lambda1520analysis*&)'
ninja: build stopped: subcommand failed.

Full log here.

[PWGLF] Update Histograms for lambda1520 task

f08b053

Update Histograms: Updated some histograms from TH3F to THnSparseF Updated some histogram binning

hkoley requested review from alibuild, njacazio, skundu692, BongHwi and smaff92 as code owners December 6, 2024 09:21

github-actions bot added the pwglf label Dec 6, 2024

hkoley added 5 commits December 6, 2024 22:03

Updated according to O2linter

787b70d

Update according to o2linter

1f28ddd

fixing o2linter warnings

20628c8

o2linter fix

9421e59

fix for o2linter

1f6f327

BongHwi previously approved these changes Dec 6, 2024

View reviewed changes

BongHwi enabled auto-merge (squash) December 6, 2024 17:15

BongHwi disabled auto-merge December 7, 2024 18:47

Update O2linter

e78b283

hkoley dismissed BongHwi’s stale review via e78b283 December 13, 2024 17:57

hkoley added 2 commits December 13, 2024 23:46

fix o2linter

bbb6104

fix o2linter

4b845af

hkoley requested a review from BongHwi December 13, 2024 19:26

njacazio previously approved these changes Jan 12, 2025

View reviewed changes

njacazio enabled auto-merge (squash) January 12, 2025 06:28

Fix O2linter

16b13f4

auto-merge was automatically disabled January 12, 2025 15:47
Head branch was pushed to by a user without write access

hkoley dismissed njacazio’s stale review via 16b13f4 January 12, 2025 15:47

Update fix O2linter

c9b214a

hkoley closed this Jan 12, 2025

hkoley deleted the patch-2 branch January 12, 2025 16:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PWGLF] Update Histograms for lambda1520 task #8844

[PWGLF] Update Histograms for lambda1520 task #8844

hkoley commented Dec 6, 2024

BongHwi commented Dec 6, 2024

alibuild commented Dec 7, 2024 •

edited

Loading

hkoley commented Jan 12, 2025

alibuild commented Jan 12, 2025

[PWGLF] Update Histograms for lambda1520 task #8844

[PWGLF] Update Histograms for lambda1520 task #8844

Conversation

hkoley commented Dec 6, 2024

BongHwi commented Dec 6, 2024

alibuild commented Dec 7, 2024 • edited Loading

hkoley commented Jan 12, 2025

alibuild commented Jan 12, 2025

alibuild commented Dec 7, 2024 •

edited

Loading