[PWGJE] Add hadron-photon correlation analysis task #8727
+807
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pestratm
requested review from
alibuild,
maoyx,
nzardosh,
fjonasALICE,
mfasDa and
mhemmer-cern
as code owners
pestratm
force-pushed
the
chargedjetsphotoncorrelation
branch
from
6c3aa72 to
175fc64
Compare
nzardosh
reviewed
Nov 29, 2024
| Service<o2::framework::O2DatabasePDG> pdg; | ||
|
|
||
| // Constrain azimuthal angle and project it to range [lower_phi, lower_phi + pi/2] | ||
| float constrainAngle(float phi, float lower_phi) |
There was a problem hiding this comment.
you should use the function in recodecay for this
| bool initTrack(const T& track, bool checkIsGlobalTrack = true) | ||
| { | ||
|
|
||
| if (checkIsGlobalTrack && !track.isGlobalTrack()) { |
There was a problem hiding this comment.
what is isGlobalTrack? is this part of the track selection? If so you can use the format in the jetderiveddata to check this
|
|
||
| /********************************************** DATA ***********************************************/ | ||
|
|
||
| void processTrigsReco(Join<Collisions, EvSels>::iterator const& collision, |
There was a problem hiding this comment.
Is there a reason for not using the JE derived format?
There was a problem hiding this comment.
this applies to all the process functions
There was a problem hiding this comment.
It was mainly because I wasn't sure how to use the jetderiveddata together with PCM and with TPC Pid
There was a problem hiding this comment.
I have now changed it to use jetderiveddata
There was a problem hiding this comment.
Edit: *now, not *no
|
thanks for making the PR! I have left some general comments above |
pestratm
force-pushed
the
chargedjetsphotoncorrelation
branch
3 times, most recently
from
047b644 to
c52573a
Compare
|
There is an issue in |
|
The error message indicates that you are mixing up a std:: vector of type unsigned long and one of type unsigned long long. Please check: Since you didn't change the code there I assume that there might have been an update on the arm side and it's more strict or something. |
|
I am not sure where this could be mixed up. I only use two vectors in my task (of type double for histogram binning, unrelated to eventselection-qa). For the event selection, I use the general event selection for jet derived data: @nzardosh Were there any major changes with the jet event selection or anything else I did not consider? |
|
I think its not your fault, its just that your build is compiling that header since its included in your task. You should contact the people responsible for that task to fix it |
pestratm
force-pushed
the
chargedjetsphotoncorrelation
branch
3 times, most recently
from
cf614cb to
2ac6884
Compare
|
Changed the pt axes to be configurable |
pestratm
force-pushed
the
chargedjetsphotoncorrelation
branch
from
2ac6884 to
1c67576
Compare
|
Fixed issue where all V0s where taken, not just from the respective collision |
|
Error while checking build/O2Physics/o2 for 1c67576 at 2024-12-12 15:28: Full log here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analysis task for angular correlations between trigger hadrons (as proxy for jets) and photons
@fjonasALICE @nzardosh