-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PWGLF] Add new task for MFT Pb-Pb #8425
Conversation
@gbencedi it is not properly communicated, but probably the easiest way to apply the required formatting is to accept the PR the format test workflow creates in your fork: gbencedi#12 |
[PWGLF] Please consider the following formatting changes to AliceO2Group#8425
I think it is communicated very well. https://aliceo2group.github.io/analysis-framework/docs/gettingstarted/contributingtocode.html#automatic-checks |
/// @brief process fnc. to run on MC w FT0C centrality selection | ||
void processMCCent( | ||
filtMcGenColls::iterator const& mccollision, | ||
soa::SmallGroups<soa::Join<filtCollsCent, aod::McCollisionLabels>> const& collisions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that having Filtered
not as an outermost template (although inside SmallGroups
) makes it ineffective. If you want the filters to be applied to collisions here, you need
soa::SmallGroups<soa::Filtered<soa::Join<aod::Collisions, aod::EvSels, aod::McCollisionsLabels>>>>
As a general rule - the process function argument needs to have an explicit Filtered
to be considered as a target for applying filters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I will fix that in another commit later on. Thanks for taking a careful look.
Error while checking build/O2Physics/o2 for 90fdb9f at 2024-11-18 09:14:
Full log here. |
Co-authored-by: ALICE Action Bot <[email protected]>
Co-authored-by: ALICE Action Bot <[email protected]>
Co-authored-by: ALICE Action Bot <[email protected]>
No description provided.