Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWGLF] Add new task for MFT Pb-Pb #8425

Merged
merged 7 commits into from
Nov 19, 2024
Merged

Conversation

gbencedi
Copy link
Collaborator

No description provided.

@aalkin
Copy link
Member

aalkin commented Nov 13, 2024

@gbencedi it is not properly communicated, but probably the easiest way to apply the required formatting is to accept the PR the format test workflow creates in your fork: gbencedi#12

[PWGLF] Please consider the following formatting changes to AliceO2Group#8425
@vkucera
Copy link
Collaborator

vkucera commented Nov 13, 2024

@gbencedi it is not properly communicated, but probably the easiest way to apply the required formatting is to accept the PR the format test workflow creates in your fork: gbencedi#12

I think it is communicated very well. https://aliceo2group.github.io/analysis-framework/docs/gettingstarted/contributingtocode.html#automatic-checks

@gbencedi
Copy link
Collaborator Author

@aalkin @vkucera Indeed it is written well in the docs, only the notification about what to do was not straightforward for me at the beginning

/// @brief process fnc. to run on MC w FT0C centrality selection
void processMCCent(
filtMcGenColls::iterator const& mccollision,
soa::SmallGroups<soa::Join<filtCollsCent, aod::McCollisionLabels>> const& collisions,
Copy link
Member

@aalkin aalkin Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that having Filtered not as an outermost template (although inside SmallGroups) makes it ineffective. If you want the filters to be applied to collisions here, you need
soa::SmallGroups<soa::Filtered<soa::Join<aod::Collisions, aod::EvSels, aod::McCollisionsLabels>>>>

As a general rule - the process function argument needs to have an explicit Filtered to be considered as a target for applying filters.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will fix that in another commit later on. Thanks for taking a careful look.

@njacazio njacazio enabled auto-merge (squash) November 13, 2024 11:30
@alibuild
Copy link
Collaborator

alibuild commented Nov 14, 2024

Error while checking build/O2Physics/o2 for 90fdb9f at 2024-11-18 09:14:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/daily-20241118-0000/daily-20241118-0000/Utilities/rANS/benchmarks/bench_ransDecode.cxx:163:17: fatal error: error writing to /tmp/cc47tmdU.s: No space left on device
/sw/SOURCES/O2/daily-20241118-0000/daily-20241118-0000/Utilities/rANS/benchmarks/bench_ransEncode.cxx:352:17: fatal error: error writing to /tmp/ccTbdRQp.s: No space left on device
/sw/SOURCES/O2/daily-20241118-0000/daily-20241118-0000/Utilities/rANS/test/test_ransSymbolTables.cxx:145:1: fatal error: error writing to /tmp/ccSOX1jD.s: No space left on device
/sw/SOURCES/O2/daily-20241118-0000/daily-20241118-0000/Framework/Foundation/3rdparty/catch2/catch_amalgamated.cxx:10791:1: fatal error: error writing to /tmp/ccQPUaGV.s: No space left on device
/sw/SOURCES/O2/daily-20241118-0000/daily-20241118-0000/Utilities/rANS/test/test_ransEncodeDecode.cxx:145:2: fatal error: error writing to /tmp/ccOoo7hE.s: No space left on device
ninja: build stopped: subcommand failed.

Full log here.

@njacazio njacazio merged commit 3450f09 into AliceO2Group:master Nov 19, 2024
16 checks passed
christianreckziegel pushed a commit to christianreckziegel/O2Physics that referenced this pull request Nov 19, 2024
joachimckh pushed a commit to joachimckh/O2Physics that referenced this pull request Dec 2, 2024
joachimckh pushed a commit to joachimckh/O2Physics that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants