PWGJE: Implementing background subtraction for jets into the framework and adding self contained HF format #4368
Conversation
nzardosh
requested review from
alibuild,
maoyx,
ddobrigk,
mfasDa,
vkucera,
fcolamar,
fgrosa,
fcatalan92,
mfaggin,
mmazzilli,
deepathoms,
NicoleBastid,
jgrosseo,
iarsene,
ktf and
a team
as code owners
adding HF stuff bug fixes debugging checks
|
Hi @nzardosh, approved - however, now that I look at the compilation status: it might be worthwhile to check the compilation error as sometimes clang is correct in catching the misuse of |
Thanks, I've tried to fix them. Shame they don't show up locally |
| template <typename TPt, typename TPhi, typename TM> | ||
| auto pz(TPt pt, TPhi eta, TM m) | ||
| { | ||
| return std::sqrt(pt * pt + m * m) * std::sinh(y(pt, eta, m)); | ||
| } |
There was a problem hiding this comment.
To be simplified. Mass is not needed.
| DECLARE_SOA_DYNAMIC_COLUMN(Pz, pz, //! D0 px | ||
| [](float pt, float eta) -> float { return functions::pz(pt, eta, o2::constants::physics::MassD0); }); | ||
| DECLARE_SOA_DYNAMIC_COLUMN(P, p, //! D0 momentum | ||
| [](float pt, float eta, float phi) -> float { return RecoDecay::p(functions::px(pt, phi), functions::py(pt, phi), functions::pz(pt, eta, o2::constants::physics::MassD0)); }); |
There was a problem hiding this comment.
To be simplified. Mass is not needed.
…k and adding self contained HF format (AliceO2Group#4368) * PWGJE: Implementing background subtraction for jets into the framework adding HF stuff bug fixes debugging checks * fixing macosarm problems --------- Co-authored-by: Nima Zardoshti <[email protected]>
…k and adding self contained HF format (AliceO2Group#4368) * PWGJE: Implementing background subtraction for jets into the framework adding HF stuff bug fixes debugging checks * fixing macosarm problems --------- Co-authored-by: Nima Zardoshti <[email protected]>
adding HF stuff
bug fixes
debugging checks