Fix rounding inequalities and allow Makefile to choose between python and python3 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxleDrut
changed the title
MaxleDrut
force-pushed
the
mdrutel-fix-array-equal-rounding-unequalities
branch
3 times, most recently
from
4ad5ac9 to
ce74263
Compare
MaxleDrut
force-pushed
the
mdrutel-fix-array-equal-rounding-unequalities
branch
from
ce74263 to
5c6fcab
Compare
MaxleDrut
commented
Sep 27, 2023
|
Seen IRL and did further tests. I ensured The Makefile hence used |
jrj-d
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some machines including mine were having float rounding issues when translating some gates (the state phase was equal to 1 + 1e-18j which was not equal to 1)
This PR replaces the array_equal function by allclose, using the default thresholds to ensure this comparison will work even with float issues. It also improves the Makefile to detect if
python3is an available command on the users machine to use it instead.Safe to revert.