Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cascading.jl #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

PyDataBlog
Copy link

Currently matchFirst function isn't exported and since this is a key extraction function commonly expected to be used, this function should be exported for ease of access. What do you think?

Currently matchFirst function isn't exported and since this is a key extraction function commonly expected to be used, this function should be exported for ease of access. What do you think?
@aviks
Copy link
Collaborator

aviks commented Jun 24, 2021

Investigating why this function needs exporting, I realised, our usage here is slightly different from base.

I think matchfirst should just become Base.match. We do have a match function, but that behaves differently from how base sees that function. I think we should lean in to base, and make matchfirst become match.

What do you think?

@PyDataBlog
Copy link
Author

I think leaning on base is the right choice too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants