Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CS to 0.7 and GB to 0.5 #300

Merged
merged 6 commits into from
Jan 30, 2025
Merged

Update CS to 0.7 and GB to 0.5 #300

merged 6 commits into from
Jan 30, 2025

Conversation

lukem12345
Copy link
Member

No description provided.

@lukem12345
Copy link
Member Author

lukem12345 commented Jan 29, 2025

@quffaro Results of discussion:

  • Update Artifacts.toml to load PIOMAS data saved on github
  • Merge into main
  • Rebase docs PR#296 on main
  • Merge docs into main
  • Trigger patch release

Tagging @GeorgeR227 just for SA

@lukem12345
Copy link
Member Author

Ran into too many issues using PIOMAS via Artifact system, relative path weirdness via Documenter, complications using an artifact in the docs environment. Workarounds that worked for others did not appear to work here. We can postpone downloading this data from the Github server, and download it from the CISE servers for the time being.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.09%. Comparing base (d206261) to head (03cb80b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   78.09%   78.09%           
=======================================
  Files           5        5           
  Lines         630      630           
=======================================
  Hits          492      492           
  Misses        138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukem12345 lukem12345 merged commit 94c7a88 into main Jan 30, 2025
10 of 11 checks passed
@lukem12345 lukem12345 deleted the llm/cs07 branch January 30, 2025 05:16
quffaro pushed a commit that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant