Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSEXP-2627 Update release section with ecosystem updates #843

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

gionn
Copy link
Member

@gionn gionn commented Apr 19, 2024

No description provided.

@gionn gionn requested review from alxgomz and pmacius April 19, 2024 08:05
@gionn gionn self-assigned this Apr 19, 2024
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced we should do that just with the release PR.

@gionn
Copy link
Member Author

gionn commented Apr 19, 2024

I'm not convinced we should do that just with the release PR.

as a reminder for the worst case, because if we are not actively adding new feature in the playbook we are never gonna merge dependency updates

@alxgomz
Copy link
Contributor

alxgomz commented Apr 22, 2024

I'm not convinced we should do that just with the release PR.

as a reminder for the worst case, because if we are not actively adding new feature in the playbook we are never gonna merge dependency updates

Yes I understand the motivation but bumping libs more or less blindly just before release sounds risky. Maybe we should be more diligent in reviewing dependabot pr BEFORE testing week instead.

@gionn
Copy link
Member Author

gionn commented Apr 22, 2024

our test coverage is pretty high here, I've zero concerns merging dependencies if build is green. Most of them are actually just test dependencies and would not impact the end users.

@gionn gionn merged commit 4323a12 into master Apr 22, 2024
4 checks passed
@gionn gionn deleted the OPSEXP-2627-docs-pr branch April 22, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants