Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-2954 Support ubuntu 24.04 #1020

Merged
merged 10 commits into from
Jan 17, 2025
Merged

OPSEXP-2954 Support ubuntu 24.04 #1020

merged 10 commits into from
Jan 17, 2025

Conversation

gionn
Copy link
Member

@gionn gionn commented Jan 13, 2025 •
edited
Loading

@gionn gionn self-assigned this Jan 13, 2025
@gionn gionn changed the title Test some on ubuntu 24.04 OPSEXP-2954 Test some on ubuntu 24.04 Jan 13, 2025
@gionn gionn force-pushed the OPSEXP-2954-ubuntu-2404 branch from 689032f to d1d3b6f Compare January 13, 2025 14:11
@gionn gionn changed the title OPSEXP-2954 Test some on ubuntu 24.04 OPSEXP-2954 Support ubuntu 24.04 Jan 15, 2025
@gionn gionn added the ec2-test Triggers ec2 integrations tests label Jan 15, 2025
@gionn gionn requested review from alxgomz and pmacius January 15, 2025 15:08
@gionn gionn marked this pull request as ready for review January 15, 2025 15:27
pmacius
pmacius reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@pmacius pmacius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic stuff but we can update .ansible-lint-ignore file. I also see

roles/postgres/vars/Ubuntu20.yml var-naming[no-role-prefix]
roles/postgres/vars/Ubuntu22.yml var-naming[no-role-prefix]

there but in postgres role we have only ubuntu18 vars

@gionn
Copy link
Member Author

gionn commented Jan 16, 2025

but we can update .ansible-lint-ignore file

see #1026 🪄

@gionn gionn requested a review from pmacius January 16, 2025 09:02
@gionn gionn merged commit 6935859 into master Jan 17, 2025
73 checks passed
@gionn gionn deleted the OPSEXP-2954-ubuntu-2404 branch January 17, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmacius pmacius pmacius approved these changes

@alxgomz alxgomz alxgomz approved these changes

Assignees

@gionn gionn

Labels
ec2-test Triggers ec2 integrations tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gionn @alxgomz @pmacius