-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using #each in Markdown #7
Comments
No, it doens't work. I didn't implement this case. I will try to make it work. |
Check the v2.6.0 on the NPM. I added support for tables in each blocks. |
Excellent! Now I'm wondering whether #if is supported and if it can be nested. For example, these do not work currently. Should they?
and
|
Minor documentation typo: At https://alexxnb.github.io/svelte-preprocess-markdown/, "handeled" should be "handled". Great work by the way! |
No, it doesn't work now. My suggesion is to filter
Will check tomorrow
Yeah, my english is poor. Thanks =) |
Will the blank line be added by formatters, if you will write Your example does not looks like valid MD table. By the way, MDSv syntax is not valid MD and is not valid Svelte. So Prettier never will work correctly with this format. |
If I remove the spaces around the dashes and save the file in VS Code, something (maybe Prettier) is putting them back in. I don't expect there is anything you can do about this. I think the only think left to consider for this issue is whether your library can support nested |
Reworked table handling, now it supports all logic for tables. Check tested cases here https://raw.githubusercontent.com/AlexxNB/svelte-preprocess-markdown/master/tests/9-table-in-each.md Try v2.7.0 on NPM. |
@mvolkmann will you mention my preprocessor in your book? =) |
It’s already there! I’ll send you a PDF of the appendix that shows how to use it. You can review it and let me know if you think there should be any changes in how I describe it.
…---
R. Mark Volkmann
Object Computing, Inc.
On Mar 2, 2020, at 2:15 AM, Alexey Schebelev ***@***.***> wrote:
@mvolkmann will you mention my preprocessor in your book? =)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Awesome! =) |
Here is a PDF of the current version of the book appendix that covers your
library.
I'm open to any feedback you have on this.
…On Mon, Mar 2, 2020 at 6:07 AM Alexey Schebelev ***@***.***> wrote:
Awesome! =)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7?email_source=notifications&email_token=AAATLUBC4LOBAOVDG5QK5ZTRFOOQHA5CNFSM4K5HZEX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENPB6RY#issuecomment-593370951>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAATLUBFUWZQBZM5LM4YNU3RFOOQHANCNFSM4K5HZEXQ>
.
--
R. Mark Volkmann
Object Computing, Inc.
|
Sorry, can't figure out the "here" place =) |
I only see v2.7.0 on npm. Did you maybe not publish it yet?
I sent you the PDF on Discord.
…On Mon, Mar 2, 2020 at 2:12 AM Alexey Schebelev ***@***.***> wrote:
I think the only think left to consider for this issue is whether your
library can support nested #each and #if blocks.
Reworked table handeling, now it supports all logic for tables. Check
tested cases here
https://raw.githubusercontent.com/AlexxNB/svelte-preprocess-markdown/master/tests/9-table-in-each.md
Try v2.8.0 on NPM.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7?email_source=notifications&email_token=AAATLUE7SNEMUJGU5ACWBNLRFNS5TA5CNFSM4K5HZEX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENOKKXA#issuecomment-593274204>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAATLUGKWK5FBNM4PKY63L3RFNS5TANCNFSM4K5HZEXQ>
.
--
R. Mark Volkmann
Object Computing, Inc.
|
I edited the comment after found wrong version there. You are tracking issues by email, so you have only first version of the comment. v.2.7.0 is the last at the moment with implemented nested logic. You may be interesting with
will be processed to: <table>
...
<tr><td colspan="num_of_columns_in_the_head>">No entries</td></tr>
...
</table> Maybe it is good idea to add |
Thanks Alexey! |
You are welcome. Will buy the papper book as soon as published. =) |
Should this work? The first hardcoded table does work. The second one that uses
#each
does not. It puts the whole row, including the vertical bars, in the first column of each row.The text was updated successfully, but these errors were encountered: